-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Remove the 'dns' options from libvirt #182
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eparis If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR requires dmacvicar/terraform-provider-libvirt#376 |
Looks like it's from coreos/tectonic-installer#3213. It came in with a bunch of other libvirt stuff, and I didn't see any notes motivating this property specifically. |
I tried to just rip and out and see what broke. Turns out, DNS query loops are bad. |
5373f16
to
7bf17a5
Compare
This will allow the libvirt nodes to use the hypervisor's DNS instead of having to hard code some upstream DNS server. Previously this was a problem if your local machine pointed to the libvirt dnsmasq for DNS resolution of the nodes. Any unknown address would cause an inifnite loop. Now, the libvirt dnsmasq will respond that the name is unknown instead of forwarding it to the hypervisor's DNS server. Since i can't see a reason for the DNS option, I take it out. Now it 'just works'.
7bf17a5
to
ab50e30
Compare
@eparis: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Obsoleted by #214? |
This will allow the libvirt nodes to use the hypervisor's DNS instead of
having to hard code some upstream DNS server. Previously this was a
problem if your local machine pointed to the libvirt dnsmasq for DNS
resolution of the nodes. Any unknown address would cause an inifnite
loop. Now, the libvirt dnsmasq will respond that the name is unknown
instead of forwarding it to the hypervisor's DNS server.
Since i can't see a reason for the DNS option, I take it out. Now it
'just works'.