Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: revert to older libvirt provider implementation #219

Closed
wants to merge 3 commits into from
Closed

*: revert to older libvirt provider implementation #219

wants to merge 3 commits into from

Conversation

crawford
Copy link
Contributor

@crawford crawford commented Sep 6, 2018

These changes ended up being problematic. We'll have to follow-up with upstream.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2018
@openshift-ci-robot
Copy link
Contributor

@crawford: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/build-tarball 4a5c7e9 link /test build-tarball

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@crawford
Copy link
Contributor Author

crawford commented Sep 6, 2018

/hold
@abhinavdahiya is still seeing the failures...

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2018
@sjenning
Copy link
Contributor

sjenning commented Sep 7, 2018

this also does not fix the issue for me. with either crawford or dmacvicar terraform-provider-libvirt.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Sep 7, 2018

I filed an issue dmacvicar/terraform-provider-libvirt#402 with scoped down main.tf.

@sjenning @crawford can you try applying the maint.tf from that issue with TF_LOG=debug and comment your logs there if you encounter failure or not.

I seem to have magically fixed my error today after restarting my computer with installer's master :/

@steveej
Copy link
Contributor

steveej commented Sep 7, 2018

I seem to have magically fixed my error today after restarting my computer with installer's master :/

I thought the same when I got started this morning, but after a while the issues started to appear again.

@abhinavdahiya
Copy link
Contributor

@crawford crawford closed this Sep 7, 2018
@crawford crawford deleted the libvirt branch September 7, 2018 16:44
@wking
Copy link
Member

wking commented Sep 7, 2018

Cross-linking #226 (a workaround for the libvirt bug).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants