-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: revert to older libvirt provider implementation #219
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@crawford: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
this also does not fix the issue for me. with either crawford or dmacvicar terraform-provider-libvirt. |
I filed an issue dmacvicar/terraform-provider-libvirt#402 with scoped down @sjenning @crawford can you try applying the I seem to have magically fixed my error today after restarting my computer with installer's master :/ |
I thought the same when I got started this morning, but after a while the issues started to appear again. |
Cross-linking #226 (a workaround for the libvirt bug). |
These changes ended up being problematic. We'll have to follow-up with upstream.