Bug 1745004: baremetal: Clarify comment in startironic.sh.template #2281
Conversation
This comment should have been adjusted following code-review updates in openshift#2249 but I missed it, now we are using the --format option clarify the comment to explain the multiple templating
openshift-ci-robot
added
the
size/XS
|
/label platform/baremetal |
|
@hardys: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
hardys
changed the title
|
@hardys: This pull request references Bugzilla bug 1745004, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
hardys
changed the title
hardys
changed the title
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
@hardys: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hardys
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@hardys: This pull request references Bugzilla bug 1745004, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1106/ |
|
/cc @abhinavdahiya apologies but I missed this yesterday when addressing your review feedback |
|
@hardys: GitHub didn't allow me to request PR reviews from the following users: feedback, apologies, missed, this, yesterday, addressing, review, but, I, when, your. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@hardys: All pull requests linked via external trackers have merged. Bugzilla bug 1745004 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This comment should have been adjusted following code-review
updates in #2249 but I missed it, now we are using the --format
option clarify the comment to explain the multiple templating