-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1745907: upi/gcp: enable manual DNS entry for *.apps #2289
Conversation
Previously, the api load balancer only contained the bootstrap instance while the installer was waiting for bootstrap-complete. This caused a race condition where occassionally the bootstrap node would shutdown its API before the installer detected bootstrap-complete. Now that we have the gcp-routes.service, we no longer need to pivot the load balancers. By adding the control plane instances to the load balancers initially, we avoid this race condition.
This change fixes an issue where some gcloud commands would fail if the resources were in a different region than the configured default region.
@jstuever: This pull request references Bugzilla bug 1745907, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jstuever: This pull request references Bugzilla bug 1745907, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@jstuever: This pull request references Bugzilla bug 1745907, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jstuever: This pull request references Bugzilla bug 1745907, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@jstuever: This pull request references Bugzilla bug 1745907, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ff31dc7
to
9f7ac86
Compare
This change adds documentation for how to remove DNS automation from the ingress-router and create the records manually.
@jstuever: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jstuever: All pull requests linked via external trackers have merged. Bugzilla bug 1745907 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
… creation I just dropped this in at the end in 14e0691 (docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221), but you need it for a functioning cluster (something about console and OAuth and mumble mumble). Jeremiah got the placement right for GCP in 16d4d38 (upi/gcp: document manual creation of apps DNS records, 2019-08-29, openshift#2289). This commit updates AWS to match.
… creation I just dropped this in at the end in 14e0691 (docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221), but you need it for a functioning cluster (something about console and OAuth and mumble mumble). Jeremiah got the placement right for GCP in 16d4d38 (upi/gcp: document manual creation of apps DNS records, 2019-08-29, openshift#2289). This commit updates AWS to match.
… creation I just dropped this in at the end in 14e0691 (docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221), but you need it for a functioning cluster (something about console and OAuth and mumble mumble). Jeremiah got the placement right for GCP in 16d4d38 (upi/gcp: document manual creation of apps DNS records, 2019-08-29, openshift#2289). This commit updates AWS to match.
Multiple documentation changes to assist with the successful deployment of gcp upi clusters.
*.apps
DNS records and how to add them manually.