Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1745907: upi/gcp: enable manual DNS entry for *.apps #2289

Merged
merged 3 commits into from
Aug 30, 2019

Conversation

jstuever
Copy link
Contributor

@jstuever jstuever commented Aug 29, 2019

Multiple documentation changes to assist with the successful deployment of gcp upi clusters.

  • Document how to disable automation of the *.apps DNS records and how to add them manually.
  • Specify the region in certain gcloud invocations for when it differs from the default region.
  • Removes the api load balancer pivot in order to remove bootstrap-complete race condition.

Previously, the api load balancer only contained the bootstrap instance
while the installer was waiting for bootstrap-complete. This caused a
race condition where occassionally the bootstrap node would shutdown its
API before the installer detected bootstrap-complete.

Now that we have the gcp-routes.service, we no longer need to pivot
the load balancers. By adding the control plane instances to the load
balancers initially, we avoid this race condition.
This change fixes an issue where some gcloud commands would fail if the
resources were in a different region than the configured default region.
@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 29, 2019
@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1745907, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

[WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1745907, which is valid.

In response to this:

[WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1745907, which is valid.

In response to this:

[WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2019
@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1745907, which is valid.

In response to this:

[WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jstuever: This pull request references Bugzilla bug 1745907, which is valid.

In response to this:

[WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever jstuever force-pushed the bz1745907 branch 4 times, most recently from ff31dc7 to 9f7ac86 Compare August 30, 2019 00:11
@jstuever jstuever changed the title [WIP] Bug 1745907: upi/gcp: enable manual DNS entry for *.apps Bug 1745907: upi/gcp: enable manual DNS entry for *.apps Aug 30, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2019
docs/user/gcp/install_upi.md Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2019
This change adds documentation for how to remove DNS automation
from the ingress-router and create the records manually.
@openshift-ci-robot
Copy link
Contributor

@jstuever: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 16d4d38 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ca19f18 into openshift:master Aug 30, 2019
@openshift-ci-robot
Copy link
Contributor

@jstuever: All pull requests linked via external trackers have merged. Bugzilla bug 1745907 has been moved to the MODIFIED state.

In response to this:

Bug 1745907: upi/gcp: enable manual DNS entry for *.apps

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jstuever jstuever deleted the bz1745907 branch September 4, 2019 19:41
wking added a commit to wking/openshift-installer that referenced this pull request Oct 10, 2019
… creation

I just dropped this in at the end in 14e0691
(docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221),
but you need it for a functioning cluster (something about console and
OAuth and mumble mumble).  Jeremiah got the placement right for GCP in
16d4d38 (upi/gcp: document manual creation of apps DNS records,
2019-08-29, openshift#2289).  This commit updates AWS to match.
alaypatel07 pushed a commit to alaypatel07/installer that referenced this pull request Nov 13, 2019
… creation

I just dropped this in at the end in 14e0691
(docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221),
but you need it for a functioning cluster (something about console and
OAuth and mumble mumble).  Jeremiah got the placement right for GCP in
16d4d38 (upi/gcp: document manual creation of apps DNS records,
2019-08-29, openshift#2289).  This commit updates AWS to match.
jhixson74 pushed a commit to jhixson74/installer that referenced this pull request Dec 6, 2019
… creation

I just dropped this in at the end in 14e0691
(docs/user/aws/install_upi: Document bring-your-own-DNS, 2019-08-14, openshift#2221),
but you need it for a functioning cluster (something about console and
OAuth and mumble mumble).  Jeremiah got the placement right for GCP in
16d4d38 (upi/gcp: document manual creation of apps DNS records,
2019-08-29, openshift#2289).  This commit updates AWS to match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants