Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/asset/installconfig: Add _CI_ONLY_STAY_AWAY_OPENSHIFT_INSTALL_AWS_USER_TAGS #364

Merged
merged 2 commits into from
Sep 28, 2018
Merged

pkg/asset/installconfig: Add _CI_ONLY_STAY_AWAY_OPENSHIFT_INSTALL_AWS_USER_TAGS #364

merged 2 commits into from
Sep 28, 2018

Commits on Sep 28, 2018

  1. pkg/asset/installconfig: Pass platforms as JSON 

    Instead of as an array of strings.  This makes it much easier to add
control over additional properties, because the consuming logic
remains "just unpack the JSON into the appropriate structure".
    @wking
    wking committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    6e8e960 View commit details
    Browse the repository at this point in the history

  2. pkg/asset/installconfig: Add _CI_ONLY_STAY_AWAY_OPENSHIFT_INSTALL_AWS… 

    …_USER_TAGS

With a JSON string containing the intended values.

This is not how we're going to expose this long-term, so I'm using an
embarrassing name and not documenting the enviroment variable.  But I
want this so we can get back to tagging expirationData in CI, without
waiting for asset state <-> disk (de)serialization.
    @wking
    wking committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    98a3531 View commit details
    Browse the repository at this point in the history