-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openshift-install ignition convert
#4300
Conversation
The transition to Ignition Spec 3 with 4.6 creates a discontinuity. Some users want to update their bootimages, e.g. for a cluster originally provisioned as 4.4 but upgraded in place to 4.6, it should be possible to directly use RHCOS 4.6 bootimages for new workers. In some cases in fact, this could be *required* for things like adding a node with newer hardware. The main stumbling block here is the pointer ignition config. Since `openshift-install` already includes Ignition bits, let's add translation capability here using https://github.com/coreos/ign-converter the same as the MCO uses. xref openshift/enhancements#492 (comment) xref https://bugzilla.redhat.com/show_bug.cgi?id=1884750
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We've hit this when porting some of our UPI tests as well as the proxy test - that one we ported to FCOS, but if we'd had this PR we could have kept the spec2 configs for a while and used this to upconvert. |
My gut reaction to this is that it is not an appropriate command for |
Agree. However, today we have a model where admins often need to download Plus
Yeah, that was my original proposal as well...I dunno. I flip-flopped based on the above but yeah I am OK with doing |
OK moved to openshift/oc#628 |
The transition to Ignition Spec 3 with 4.6 creates a
discontinuity. Some users want to update their bootimages,
e.g. for a cluster originally provisioned as 4.4 but upgraded
in place to 4.6, it should be possible to directly use RHCOS 4.6
bootimages for new workers.
In some cases in fact, this could be required for things like
adding a node with newer hardware.
The main stumbling block here is the pointer ignition config.
Since
openshift-install
already includes Ignition bits, let'sadd translation capability here using
https://github.com/coreos/ign-converter
the same as the MCO uses.
xref openshift/enhancements#492 (comment)
xref https://bugzilla.redhat.com/show_bug.cgi?id=1884750