Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openshift-install ignition convert #4300

Closed
wants to merge 1 commit into from

Conversation

cgwalters
Copy link
Member

The transition to Ignition Spec 3 with 4.6 creates a
discontinuity. Some users want to update their bootimages,
e.g. for a cluster originally provisioned as 4.4 but upgraded
in place to 4.6, it should be possible to directly use RHCOS 4.6
bootimages for new workers.

In some cases in fact, this could be required for things like
adding a node with newer hardware.

The main stumbling block here is the pointer ignition config.
Since openshift-install already includes Ignition bits, let's
add translation capability here using
https://github.com/coreos/ign-converter
the same as the MCO uses.

xref openshift/enhancements#492 (comment)
xref https://bugzilla.redhat.com/show_bug.cgi?id=1884750

The transition to Ignition Spec 3 with 4.6 creates a
discontinuity.  Some users want to update their bootimages,
e.g. for a cluster originally provisioned as 4.4 but upgraded
in place to 4.6, it should be possible to directly use RHCOS 4.6
bootimages for new workers.

In some cases in fact, this could be *required* for things like
adding a node with newer hardware.

The main stumbling block here is the pointer ignition config.
Since `openshift-install` already includes Ignition bits, let's
add translation capability here using
https://github.com/coreos/ign-converter
the same as the MCO uses.

xref openshift/enhancements#492 (comment)
xref https://bugzilla.redhat.com/show_bug.cgi?id=1884750
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020
@openshift-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya after the PR has been reviewed.
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cgwalters
Copy link
Member Author

We've hit this when porting some of our UPI tests as well as the proxy test - that one we ported to FCOS, but if we'd had this PR we could have kept the spec2 configs for a while and used this to upconvert.

@staebler
Copy link
Contributor

My gut reaction to this is that it is not an appropriate command for openshift-install. The purview of openshift-install is installing clusters and destroying clusters: It is not supporting day-2 administration of clusters. As such, openshift-install is not a good home for tooling to support adding new nodes to an existing cluster. Although I do not like the idea of adding more to its hodgepodge of commands, I feel that oc is stronger candidate for this command than openshift-install.

@cgwalters
Copy link
Member Author

It is not supporting day-2 administration of clusters.

Agree. However, today we have a model where admins often need to download openshift-install and the RHCOS bootimages at the same time, so they will have both. Plus openshift-install generated these pointer configs, so it's somewhat natural to have it support converting them.

Plus openshift-install already vendors Ignition code.

I feel that oc is stronger candidate for this command than openshift-install.

Yeah, that was my original proposal as well...I dunno. I flip-flopped based on the above but yeah I am OK with doing oc.

@cgwalters
Copy link
Member Author

OK moved to openshift/oc#628

@cgwalters cgwalters closed this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants