-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary scc #434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deads2k this is not bootube. We have a separate script tectonic.sh that installs objects that cannot be installed by bootube. We will continue to have things that installer installs that don't have to be installed while bootstrapping and are not installed by CVO.. an example soon is going to be worker machinesets |
I'm fine dropping this as seems unused. Can you change this PR description? |
fixed /retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
SCCs don't exist before the CVO runs the openshift-apiserver-operator, so nothing in tectonic.sh can depend on them.
/assign @steveej @abhinavdahiya
/cc @mfojtik