baremetal: when networking is disabled make the bootstrap provisioning ip optional

[asalkeld]

This is needed by the assisted installer, so that it does not have to create static ips.

/cc @zaneb @hardys

[asalkeld]

/retest

[hardys]

/label platform/baremetal

/cc @stbenjam

[stbenjam]

Thanks @asalkeld, looks reasonable but we have to at least change this validation:

installer/pkg/types/baremetal/validation/platform.go

Lines 379 to 381 in 640a958

	if err := validateIPNotinMachineCIDR(p.BootstrapProvisioningIP, n); err != nil {
	allErrs = append(allErrs, field.Invalid(fldPath.Child("bootstrapProvisioningIP"), p.BootstrapProvisioningIP, err.Error()))
	}

I get this error when testing:

2020-11-18 08:44:02 level=fatal msg=failed to fetch Cluster: failed to fetch dependency of "Cluster": failed to generate asset "Platform Provisioning Check": platform.baremetal.bootstrapProvisioningIP: Invalid value: "": provisioning network is disabled, IP expected to be in one of the machine networks: fd2e:6f44:5dd8:c956::/120

You can test your code by removing this line from dev-scripts

https://github.com/openshift-metal3/dev-scripts/blob/38bb37338a9e69cfa312f27d5612c7fa67d0df8b/ocp_install_env.sh#L81

and checking out your installer code to $GOPATH/src/github.com/openshift/installer

and:

export KNI_INSTALL_FROM_GIT=true
export PROVISIONING_NETWORK_PROFILE=Disabled

[asalkeld]

thanks for the review @stbenjam
I have an assisted installer setup.. so i since have tested by running a " create ignition-configs" and confirming no validation errors and the output. ( startironic.sh has the interface section missing)

[stbenjam]

/lgtm

Nice, I get past bootstrap without the dedicated IP.

/assign @staebler @abhinavdahiya

Would one of you mind taking a look? It touches cluster/tfvars so we can't approve it ourselves. Thanks!

[staebler]

/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[hardys]

/lgtm

I also tested locally and this works as expected, thanks @asalkeld!

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[stbenjam]

@asalkeld In preparation for this landing, would you mind putting up a PR to dev-scripts to pull out the bootstrapProvisioningIP on 4.7?

https://github.com/openshift-metal3/dev-scripts/blob/38bb37338a9e69cfa312f27d5612c7fa67d0df8b/ocp_install_env.sh#L81

[hardys]

@asalkeld In preparation for this landing, would you mind putting up a PR to dev-scripts to pull out the bootstrapProvisioningIP on 4.7?

https://github.com/openshift-metal3/dev-scripts/blob/38bb37338a9e69cfa312f27d5612c7fa67d0df8b/ocp_install_env.sh#L81

@stbenjam @asalkeld note that we probably need to base that change on openshift-metal3/dev-scripts#1146 (or land that first) because the current OPENSHIFT_VERSION variable doesn't work in CI.

[asalkeld]

@asalkeld In preparation for this landing, would you mind putting up a PR to dev-scripts to pull out the bootstrapProvisioningIP on 4.7?
https://github.com/openshift-metal3/dev-scripts/blob/38bb37338a9e69cfa312f27d5612c7fa67d0df8b/ocp_install_env.sh#L81

@stbenjam @asalkeld note that we probably need to base that change on openshift-metal3/dev-scripts#1146 (or land that first) because the current OPENSHIFT_VERSION variable doesn't work in CI.

openshift-metal3/dev-scripts#1156

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-merge-robot]

@asalkeld: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-workers-rhel7	be2d969	link	/test e2e-aws-workers-rhel7
ci/prow/e2e-libvirt	be2d969	link	/test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.