-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
baremetal: when networking is disabled make the bootstrap provisioning ip optional #4390
baremetal: when networking is disabled make the bootstrap provisioning ip optional #4390
Conversation
/retest |
/label platform/baremetal /cc @stbenjam |
Thanks @asalkeld, looks reasonable but we have to at least change this validation: installer/pkg/types/baremetal/validation/platform.go Lines 379 to 381 in 640a958
I get this error when testing:
You can test your code by removing this line from dev-scripts and checking out your installer code to and: export KNI_INSTALL_FROM_GIT=true
export PROVISIONING_NETWORK_PROFILE=Disabled |
…ngNetwork=Disabled
…trapProvisioningIP is empty
thanks for the review @stbenjam |
/lgtm Nice, I get past bootstrap without the dedicated IP. /assign @staebler @abhinavdahiya Would one of you mind taking a look? It touches cluster/tfvars so we can't approve it ourselves. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm I also tested locally and this works as expected, thanks @asalkeld! |
/retest Please review the full test history for this PR and help us cut down flakes. |
@asalkeld In preparation for this landing, would you mind putting up a PR to dev-scripts to pull out the bootstrapProvisioningIP on 4.7? |
@stbenjam @asalkeld note that we probably need to base that change on openshift-metal3/dev-scripts#1146 (or land that first) because the current OPENSHIFT_VERSION variable doesn't work in CI. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@asalkeld: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
This is needed by the assisted installer, so that it does not have to create static ips.
/cc @zaneb @hardys