-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere Destroy: add log messages for tag destruction #4407
vSphere Destroy: add log messages for tag destruction #4407
Conversation
pkg/destroy/vsphere/vsphere.go
Outdated
@@ -217,12 +217,14 @@ func (o *ClusterUninstaller) Run() error { | |||
o.Logger.Errorln(err) | |||
return err | |||
} | |||
o.Logger.WithField("Tag", o.InfraID).Info("Destroyed") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, if we are going to add the field to the "Destroyed" log event, we should add it to the other log events for the action. Specifically, use the logger returned by the call to WithField
for the "Delete tag" log event and the error log event as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. I think the new changes are in line with this suggestion.
Prints Info message when tag and tag categories are successfully destroyed.
a0852e2
to
cb46fbf
Compare
/test e2e-vsphere |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Prints Info message when tag and tag categories are successfully destroyed.
/test e2e-vsphere