Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add instance type field to mao #451

Closed
wants to merge 1 commit into from
Closed

[WIP] Add instance type field to mao #451

wants to merge 1 commit into from

Conversation

trawler
Copy link
Contributor

@trawler trawler commented Oct 10, 2018 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: trawler
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: steveej

If they are not already assigned, you can assign the PR to them by writing /assign @steveej in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 10, 2018 •
edited
Loading

cc @derekwaynecarr

The machineset definitions for workers should move to installer.
So I would rather do that than add new options to maoconfig?

@openshift-ci-robot
Copy link
Contributor

@trawler: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/unit 61cc17d link /test unit
ci/prow/govet 61cc17d link /test govet
ci/prow/e2e-aws 61cc17d link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

This was referenced Oct 12, 2018
Closed
Closed
@crawford
Copy link
Contributor

This seems to have stalled out. Please reopen when you are ready to continue this discussion.

/close

@openshift-ci-robot
Copy link
Contributor

@crawford: Closing this PR.

In response to this:

This seems to have stalled out. Please reopen when you are ready to continue this discussion.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlevy aaronlevy Awaiting requested review from aaronlevy

@rajatchopra rajatchopra Awaiting requested review from rajatchopra

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trawler @openshift-ci-robot @abhinavdahiya @crawford