Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/asset/store: Use '%q' for formatting quoted strings #460

Merged
merged 1 commit into from
Oct 13, 2018
Merged

pkg/asset/store: Use '%q' for formatting quoted strings #460

merged 1 commit into from
Oct 13, 2018

Conversation

wking
Copy link
Member

@wking wking commented Oct 12, 2018

This saves us a few characters and gives us better handling when the string values themselves contain quotes (although only the former matters much in this case). The old manual quoting is from 971eea9 (#388).

CC @rajatchopra

@wking
pkg/asset/store: Use '%q' for formatting quoted strings
7628995 
This saves us a few characters and gives us better handling when the
string values themselves contain quotes (although only the former
matters much in this case).  The old manual quoting is from 971eea9
(pkg/asset: Save/Load functinality for assets into a state file,
2018-10-11, openshift#388).
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 12, 2018
@wking
Copy link
Member Author

wking commented Oct 12, 2018 •
edited
Loading

The e2e-aws error was:

2018/10/12 23:00:21 error: unable to signal to artifacts container to terminate in pod release-latest, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2018/10/12 23:00:25 Ran for 7m36s
error: could not run steps: failed to wait for release pod to complete: could not wait for pod completion: pod release-latest was already deleted

The images error was:

error: could not run steps: failed to wait for release pod to complete: could not wait for pod completion: pod release-latest was already deleted

And it looks like yaml-lint is still running, so I don't know why GitHub is saying it failed. Anyhow, maybe some sort of hiccup?

/retest

rajatchopra
rajatchopra approved these changes Oct 13, 2018
View reviewed changes
Copy link
Contributor

@rajatchopra rajatchopra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajatchopra, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e2547ee into openshift:master Oct 13, 2018
@wking wking deleted the q-formatting branch October 15, 2018 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajatchopra rajatchopra rajatchopra approved these changes

@crawford crawford Awaiting requested review from crawford

Assignees

@rajatchopra rajatchopra

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @openshift-ci-robot @rajatchopra @openshift-merge-robot