Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/openshift-install: Fix "intall" -> "install" typo #463

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

droslean
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 15, 2018
@crawford
Copy link
Contributor

Thanks for the commit, but this needs to be formatted properly. Please take a look at the format we use in our history and reference the contribution guide.

@wking
Copy link
Member

wking commented Oct 15, 2018

Thanks for the commit, but this needs to be formatted properly.

In this case, a commit subject like cmd/openshift-install: Fix "intall" -> "install" typo would be a much clearer hint in the logs, which currently look like:

$ git log -3 --graph --oneline --decorate origin/pr/463
* 867a9f0 (origin/pr/463) fix typo
*   e2547ee (HEAD, wking/master, origin/master, origin/HEAD, master) Merge pull request #460 from wking/q-formatting
|\  
| * 7628995 (origin/pr/460) pkg/asset/store: Use '%q' for formatting quoted strings

@droslean droslean changed the title fix typo cmd/openshift-install: Fix "intall" -> "install" typo Oct 15, 2018
@wking
Copy link
Member

wking commented Oct 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
@openshift-merge-robot openshift-merge-robot merged commit 89e130e into openshift:master Oct 15, 2018
@droslean droslean deleted the fix-typo branch October 15, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants