pkg/asset/cluster: tectonicClusterID or kubernetes.io/cluster/<name> deletion #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XXL
Generated with: $ rm -rf "$(go env GOPATH)/pkg/dep/sources" # to avoid errors like "Unable to update checked out version: fatal: reference is not a tree" # possibly [1] $ dep ensure -update using: $ dep version dep: version : v0.5.0 build date : git hash : 22125cf go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false I haven't reviewed all of these changes, but I want this to pull in openshift/hive@b1cad987 (contrib/pkg/awstagdeprovision: Allow for OR filters, 2018-10-18, openshift/hive#47). [1]: golang/dep#928 (comment)
wking
force-pushed
the
or-delete-logic
branch
from
f69e3fd
to
1412168
Compare
…deletion We're having trouble getting our resources tagged consistently, with elastic IPs, NAT gateways, etc. missing kubernetes.io/cluster/<name> [1]. Meanwhile, the ingress operator will be creating elastic load balancers that lack tectonicClusterID [2]. This change deletes everything we can find with either tag while we sort out something cleaner. [1]: openshift#458 (comment) [2]: openshift#458 (comment)
wking
force-pushed
the
or-delete-logic
branch
from
1412168
to
6e1b19a
Compare
|
The router failed to come up, but here are the cleanup logs from the last e2e-aws run: $ oc project ci-op-4ir2nrcd
$ oc logs --timestamps -f e2e-aws -c teardown | tee /tmp/teardown.logwhich generated |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having trouble getting our resources tagged consistently, with [elastic IPs, NAT gateways, etc. missing
kubernetes.io/cluster/<name> ][1]. Meanwhile, [the ingress operator will be creating elastic load balancers that lacktectonicClusterID`2. This change deletes everything we can find with either tag while we sort out something cleaner.