Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baremetal: Deploy using CoreOS ISO from the release payload #5473

Merged
merged 10 commits into from
Dec 17, 2021
Merged

Baremetal: Deploy using CoreOS ISO from the release payload #5473

merged 10 commits into from
Dec 17, 2021

Conversation

zaneb
Copy link
Member

@zaneb zaneb commented Dec 11, 2021 •
edited
Loading

Complete the implementation of Include the CoreOS image in the release for baremetal and Baremetal IPI Network Configuration by switching installation to use the CoreOS images from the machine-os-images container in the release payload, for both masters and workers. Also, customise the master network config using the image-customization-controller. (Worker network config was already set up by #5247.)

This PR depends on openshift/cluster-baremetal-operator#208.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2021
@zaneb zaneb force-pushed the machine-os-images branch 2 times, most recently from 852f313 to 111178a Compare December 12, 2021 02:05
@ardaguclu ardaguclu mentioned this pull request Dec 14, 2021
Merged
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 14, 2021
@zaneb zaneb force-pushed the machine-os-images branch 2 times, most recently from 425838d to 3b91f10 Compare December 15, 2021 06:16
@zaneb zaneb force-pushed the machine-os-images branch 4 times, most recently from 0139282 to 644207d Compare December 16, 2021 14:10
@openshift-ci openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021
@openshift-ci openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2021
@zaneb zaneb marked this pull request as ready for review December 16, 2021 14:38
@zaneb zaneb changed the title Baremetal: Get images from machine-os-images Baremetal: Deploy using CoreOS ISO from the release payload Dec 16, 2021
@zaneb
Copy link
Member Author

zaneb commented Dec 16, 2021

/label platform/baremetal

@openshift-ci openshift-ci bot added platform/baremetal IPI bare metal hosts platform and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 16, 2021
@zaneb zaneb force-pushed the machine-os-images branch 2 times, most recently from 1a9fb0b to 6fbad0d Compare December 16, 2021 17:24
@zaneb
Copy link
Member Author

zaneb commented Dec 16, 2021

Baremetal tests are not expected to pass until after openshift/cluster-baremetal-operator#208 merges.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@ardaguclu
Copy link
Member

/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-serial-ipv4
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-upgrade

@ardaguclu
Copy link
Member

/test e2e-metal-ipi-virtualmedia

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@zaneb
Copy link
Member Author

zaneb commented Dec 17, 2021

e2e-metal-ipi-ovn-ipv6-required job timed out, so kicking it again
/test e2e-metal-ipi-ovn-ipv6-required

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@staebler
Copy link
Contributor

Since e2e-metal-ipi-ovn-ipv6 passed,
/override ci/prow/e2e-metal-ipi-ovn-ipv6-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-metal-ipi-ovn-ipv6-required

In response to this:

Since e2e-metal-ipi-ovn-ipv6 passed,
/override ci/prow/e2e-metal-ipi-ovn-ipv6-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@staebler
Copy link
Contributor

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@staebler: Overrode contexts on behalf of staebler: ci/prow/e2e-aws, ci/prow/e2e-aws-upgrade

In response to this:

/override ci/prow/e2e-aws
/override ci/prow/e2e-aws-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a7c5c03 into openshift:master Dec 17, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2021

@zaneb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-virtualmedia d5eeeae link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-crc d5eeeae link false /test e2e-crc
ci/prow/e2e-ibmcloud d5eeeae link false /test e2e-ibmcloud
ci/prow/e2e-aws-workers-rhel7 d5eeeae link false /test e2e-aws-workers-rhel7
ci/prow/e2e-metal-single-node-live-iso d5eeeae link false /test e2e-metal-single-node-live-iso
ci/prow/e2e-libvirt d5eeeae link false /test e2e-libvirt
ci/prow/e2e-metal-ipi-ovn-dualstack d5eeeae link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-swapped-hosts d5eeeae link false /test e2e-metal-ipi-swapped-hosts
ci/prow/e2e-ovirt d5eeeae link false /test e2e-ovirt
ci/prow/e2e-aws-workers-rhel8 d5eeeae link false /test e2e-aws-workers-rhel8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hs0210 hs0210 mentioned this pull request Dec 21, 2021
Closed
@hs0210 hs0210 mentioned this pull request Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtantsur dtantsur dtantsur left review comments

@staebler staebler staebler left review comments

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@celebdor celebdor Awaiting requested review from celebdor

Assignees

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. platform/baremetal IPI bare metal hosts platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@zaneb @sadasu @romfreiman @staebler @openshift-bot @ardaguclu @dtantsur @openshift-merge-robot @imain