Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/asset/installconfig/platform: Drop *PlatformType for types.{platform}.Name #659

Commits on Nov 13, 2018

  1. pkg/asset/installconfig/platform: Drop *PlatformType for types.{platf…

    …orm}.Name
    
    The old *PlatformType are from cccbb37 (Generate installation assets
    via a dependency graph, 2018-08-10, openshift#120), but since 476be07
    (pkg/asset: use vendored cluster-api instead of go templates,
    2018-10-30, openshift#573), we've had variables for the name strings in the
    more central pkg/types.  With this commit, we drop the more peripheral
    forms.  I've also pushed the types.PlatformName{Platform} variables
    down into types.{platform}.Name at Ahbinav's suggestion [1].
    
    I've added a unit test to enforce sorting in PlatformNames, because
    the order is required by sort.SearchStrings in queryUserForPlatform.
    
    [1]: openshift#659 (comment)
    wking committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1e129fe View commit details
    Browse the repository at this point in the history