OCPBUGS-9982: bootstrap-pivot: skip pivot in SCOS Live ISO #6965
Conversation
openshift-ci-robot
added
jira/valid-reference
|
@vrutkovs: This pull request references Jira Issue OCPBUGS-9982, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
vrutkovs
force-pushed
the
scos-skip-pivot-on-live-iso
branch
from
e5b3a0d
to
707bbbd
Compare
|
/retest-required |
|
/approve |
|
retesting, hopefully we'll see some scos tests not get rate limited |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrutkovs
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
This comment was marked as outdated.
This comment was marked as outdated.
vrutkovs
force-pushed
the
scos-skip-pivot-on-live-iso
branch
from
707bbbd
to
a7d9218
Compare
vrutkovs
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/refresh |
|
/test okd-e2e-aws-ovn |
vrutkovs
force-pushed
the
scos-skip-pivot-on-live-iso
branch
from
a7d9218
to
ded6ddc
Compare
If bootstrap is running in a Live ISO of SCOS `rpm-ostree pivot` will fail as /usr is not writable. Live ISO is used in assisted-installer flow and it doesn't need to pivot machine-os-content during bootstrap (it would write SCOS image on disk and run pivot via machine-config-daemon-pivot service). This change unblocks OKD Stream isntall using assisted-installer
vrutkovs
force-pushed
the
scos-skip-pivot-on-live-iso
branch
from
ded6ddc
to
ba72368
Compare
|
okd-scos-e2e-aws-ovn is looking good now |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@patrickdillon @jhixson74 |
|
/retest-required |
|
/lgtm |
|
@vrutkovs: Jira Issue OCPBUGS-9982: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-9982 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| # Exit early if pivot is attempted on SCOS Live ISO | ||
| {{if .IsSCOS -}} | ||
| source /etc/os-release | ||
| if [[ ! $(touch /usr/.test) ]] && [[ ${ID} =~ ^(centos)$ ]]; then |
There was a problem hiding this comment.
It's not going to work on any live ISO right? As we move towards potentially doing openshift/os#799 we'll also want to have this change for OCP/RHEL.
That said, I think the Live ISO case is going to have interesting issues here. What we probably want to support is a case where we do dynamic overlays of things like kubelet and other tools, without a reboot.
There was a problem hiding this comment.
Right, that script would fail on any LiveISO, but we run boostrap-pivot on OKD only. The CentOS guard here is because OKD SCOS can start via:
- FCOS in IPI
- LiveISO SCOS in Assisted Installer
There was a problem hiding this comment.
Right, but I'm saying we're at least potentially going to make the same change for OCP to ship disk images that are pure RHEL content. (enhancement etc. to be written; no action required now, just noting)
There was a problem hiding this comment.
Ah, yes, in that case we'll need something similar - and it would be a great opportunity to rework bootstrap-pivot entirely
|
/cherry-pick release-4.13 |
|
@vrutkovs: new pull request created: #7020 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If bootstrap is running in a Live ISO of SCOS
rpm-ostree pivotwill fail as /usr is not writable. Live ISO is used in assisted-installer flow and it doesn't need to pivot machine-os-content during bootstrap (it would write SCOS image on disk and run pivot via machine-config-daemon-pivot service).This change unblocks OKD Stream isntall using assisted-installer