Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTIARCH-4568: Print release image arch and default arch when the payload is multi #8515

Merged
merged 1 commit into from
Jul 10, 2024
Merged

MULTIARCH-4568: Print release image arch and default arch when the payload is multi #8515

merged 1 commit into from
Jul 10, 2024

Conversation

jeffdyoung
Copy link
Contributor

@jeffdyoung jeffdyoung commented May 31, 2024 •
edited
Loading

In parallel with: openshift/oc#1792

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2024 •
edited by openshift-ci bot
Loading

@jeffdyoung: This pull request references MULTIARCH-4568 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 31, 2024
@openshift-ci openshift-ci bot requested review from patrickdillon and sadasu May 31, 2024 13:36
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 31, 2024 •
edited by openshift-ci bot
Loading

@jeffdyoung: This pull request references MULTIARCH-4568 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

In parallel with: openshift/oc#1792

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jeffdyoung jeffdyoung mentioned this pull request May 31, 2024
Merged
@jeffdyoung jeffdyoung force-pushed the MULTIARCH-4568 branch 2 times, most recently from fe97fbd to 82a0a4f Compare June 20, 2024 16:13
r4f4
r4f4 reviewed Jun 20, 2024
View reviewed changes
pkg/version/version.go Outdated Show resolved Hide resolved
r4f4
r4f4 reviewed Jun 24, 2024
View reviewed changes
Copy link
Contributor

@r4f4 r4f4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left a few nitpick comments.

pkg/version/version.go Outdated Show resolved Hide resolved
pkg/version/version.go Outdated Show resolved Hide resolved
jeffdyoung
jeffdyoung commented Jun 24, 2024
View reviewed changes
cmd/openshift-install/version.go
}
fmt.Printf("release architecture %s\n", releaseArch)
if strings.Contains(releaseArch, "multi") || strings.Contains(releaseArch, "unknown") {
fmt.Printf("default architecture %s\n", version.DefaultArch())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r4f4 Thought it might be a good idea to print default arch when release arch is unknown? This would give some indication of what the installer will do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me.

@jeffdyoung jeffdyoung changed the title [WIP] MULTIARCH-4568: Print release image arch and default arch when the payload is multi MULTIARCH-4568: Print release image arch and default arch when the payload is multi Jun 24, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024 •
edited
Loading

@jeffdyoung: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade 9c22a93705c3433bee29e1c759f98ae3e2b609a5 link false /test okd-e2e-aws-ovn-upgrade
ci/prow/e2e-vsphere-ovn-upi 9c22a93705c3433bee29e1c759f98ae3e2b609a5 link true /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jeffdyoung
Copy link
Contributor Author

/retest

sadasu
sadasu reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@sadasu sadasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@r4f4 r4f4 mentioned this pull request Jul 3, 2024
Merged
3 tasks
@jeffdyoung
Copy link
Contributor Author

@zaneb @patrickdillon looks like we are good to go on the oc side: openshift/oc#1792
can we get an approved on the installer side?

@patrickdillon
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 03dfc1e into openshift:master Jul 10, 2024
17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202407102011.p0.g03dfc1e.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasu sadasu sadasu left review comments

@r4f4 r4f4 r4f4 left review comments

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@sadasu sadasu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeffdyoung @openshift-ci-robot @patrickdillon @openshift-bot @r4f4 @sadasu