Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes: Drop the old Tectonic change log #90

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

wking
Copy link
Member

@wking wking commented Jul 31, 2018

We'll start a new one when we cut our first OpenShift-branded release.

Fixes #86.

/assign @crawford

We'll start a new one when we cut our first OpenShift-branded release
[1].

[1]: openshift#86 (comment)
@openshift-ci-robot openshift-ci-robot added retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 31, 2018
@crawford
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2018
@wking
Copy link
Member Author

wking commented Aug 1, 2018

The e2e-aws error was:

2 error(s) occurred:

* module.vpc.aws_route.to_nat_gw[2]: 1 error(s) occurred:

* aws_route.to_nat_gw.2: Error finding route after creating it: Unable to find matching route for Route Table (rtb-0e55d85d8a427703a) and destination CIDR block (0.0.0.0/0).
* module.vpc.aws_route.to_nat_gw[4]: 1 error(s) occurred:

* aws_route.to_nat_gw.4: Error finding route after creating it: Unable to find matching route for Route Table (rtb-04360c65f2658e5f5) and destination CIDR block (0.0.0.0/0).

Looks like something might have removed the route we made?

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2d9f35a into openshift:master Aug 1, 2018
@wking wking deleted the drop-change-log branch August 1, 2018 02:31
stbenjam pushed a commit to openshift-metal3/installer that referenced this pull request Jun 4, 2019
Provide BareMetalMachineProviderSpec with the right fields
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
* Fix README.md

Required option --provider-os was added to generate-yaml.sh in openshift#90.
This patch fixes Cluster Creation section in README.md.

* Apply suggestions from code review

Co-Authored-By: hidekazuna <hidekazuna@gmail.com>
EmilienM pushed a commit to shiftstack/installer that referenced this pull request Dec 8, 2020
Bug 1810400: Port CAPO to MAO API
stbenjam pushed a commit to stbenjam/installer that referenced this pull request Feb 10, 2021
Bug 1907610: Update kubernetes deps to 1.20
miyamotoh pushed a commit to miyamotoh/installer that referenced this pull request Jan 20, 2022
Minimizing what users can specify in the install-config file after we've gotten a better understanding of things. This should minimize things a user could accidentally change, and unnecessary things we need to validate.


Closes https://issues.redhat.com/browse/MULTIARCH-2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants