-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-41642: vendor: Update openshift/api to pick up v4.17 capability sets #9013
OCPBUGS-41642: vendor: Update openshift/api to pick up v4.17 capability sets #9013
Conversation
@wking: This pull request references Jira Issue OCPBUGS-41642, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
899467f
to
7cc32fa
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: patrickdillon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label cherry-pick-approved |
/jira refresh |
@wking: This pull request references Jira Issue OCPBUGS-41642, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
7cc32fa
to
5f2a2ad
Compare
Catching up with [1], and a backport-ish of 9d1f82a (vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets, 2024-09-12, openshift#9002). Generated with: $ GOPROXY=direct go get github.com/openshift/api@release-4.17 $ go mod tidy $ go mod vendor $ go generate ./pkg/types/installconfig.go $ git add -A go.* vendor data/data/install.openshift.io_installconfigs.yaml all using: $ go version go version go1.23.1 linux/amd64 where GOPROXY=direct avoids a caching delay [2]: I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions? In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue. This will allow users to use the new capability sets in their install-config YAML. [1]: openshift/api#2023 [2]: https://proxy.golang.org/
/lgtm |
@wking: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
59a5cf9
into
openshift:release-4.17
@wking: Jira Issue OCPBUGS-41642: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-41642 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
Catching up with openshift/api/pull/2023, and a backport-ish of 9d1f82a (#9002). Generated with:
all using:
where
GOPROXY=direct
avoids a caching delay:This will allow users to use the new capability sets in their install-config YAML.