Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45692: Modified ova template name to use failure domain name #9300

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vr4manta
Copy link
Contributor

OCPBUGS-45692

Changes

  • Modified importRhcosOva() to check for max length
  • Modified importRhcosOva() to use failure domain name as part of OVA filename instead of region and zone.

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 10, 2024
@openshift-ci-robot
Copy link
Contributor

@vr4manta: This pull request references Jira Issue OCPBUGS-45692, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-45692

Changes

  • Modified importRhcosOva() to check for max length
  • Modified importRhcosOva() to use failure domain name as part of OVA filename instead of region and zone.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from vr4manta. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor Author

/test all

@vr4manta
Copy link
Contributor Author

/test all

1 similar comment
@vr4manta
Copy link
Contributor Author

/test all

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-techpreview 996b42e link false /test e2e-vsphere-ovn-techpreview
ci/prow/e2e-vsphere-ovn-zones 996b42e link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-zones-techpreview 996b42e link false /test e2e-vsphere-ovn-zones-techpreview
ci/prow/okd-scos-e2e-aws-ovn 996b42e link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-multi-vcenter-ovn 996b42e link false /test e2e-vsphere-multi-vcenter-ovn
ci/prow/images 996b42e link true /test images
ci/prow/e2e-vsphere-ovn-upi 996b42e link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-ovn-upi 996b42e link true /test e2e-aws-ovn-upi
ci/prow/golint 996b42e link true /test golint
ci/prow/okd-scos-images 996b42e link true /test okd-scos-images
ci/prow/e2e-vsphere-ovn 996b42e link true /test e2e-vsphere-ovn
ci/prow/terraform-images 996b42e link true /test terraform-images
ci/prow/e2e-azure-ovn-upi 996b42e link true /test e2e-azure-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants