-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-47477: aws: skip dead zones on us-east-1 when discovering AZs #9333
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
/test ? |
@mtulio: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-ovn |
@mtulio: This pull request references Jira Issue OCPBUGS-47477, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
LMK if this makes sense to you all. /assign @r4f4 @patrickdillon @yunjiang29 |
6ac50ff
to
0d77037
Compare
Add the method to skip undesired zones when discoverying zones from metadata. This change targets explicity to skup the zone us-east-1e which provides very limited offerings of EC2, with no EC2 supported by installer. This change prevents creating infrastructure in such zone as it will not be supported to run workloads (create instances) on it.
0d77037
to
c3af0f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@mtulio: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR introduce zone skip when installer discover the zones from metadata/AWS API.
The
us-east-1e
is a dead zone in US Virginia, create network resources on that zone is useless as it does not offers supported instance types. That zone was causing theWARNING
/failure when installing a cluster without setting the zone in IC: