Squashed all commits into one for the SSH troubleshooting guide

[ldomb]

commit c534e54
Author: Laurent Domb ldomb@redhat.com
Date: Thu Jan 3 08:32:23 2019 -0500

added fixup! updated command to verify ssh-key and removed line If SSH auth…

commit 676d92c
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 23:20:28 2019 -0500

updated command to verify ssh-key and removed line If SSH authentication is failing ...

commit 268f402
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 17:01:48 2019 -0500

added suggestion and fixed colon and ssh-key

commit 5ef154c
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 16:59:20 2019 -0500

added suggested changes to troubleshoot doc

commit 7b7f8eb
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 14:23:32 2019 -0500

removed brackets for ssh-key

commit e38ad4e
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 14:20:50 2019 -0500

fixed ssh-key to be consistent

commit 5488da0
Author: Laurent Domb ldomb@redhat.com
Date: Wed Jan 2 14:18:12 2019 -0500

addressed remaining feedback for troubleshooting of ssh

commit f1cf969
Author: Laurent Domb ldomb@redhat.com
Date: Thu Dec 6 09:54:27 2018 -0500

added more specific information around ssh troubleshooting for aws

commit d6c5b4b
Author: Laurent Domb ldomb@redhat.com
Date: Wed Dec 5 16:29:57 2018 -0500

highlight core as well

commit fade1f8
Author: Laurent Domb ldomb@redhat.com
Date: Wed Dec 5 16:27:42 2018 -0500

added some more specifics to get ssh working for users which are not familiar with coreos

[openshift-ci-robot]

Hi @ldomb. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ldomb]

/assign @wking

[wking]

Can you rework the commit message? The subject is not very specific now:

$ git log --oneline -1 origin/pr/986
c910e4d Squashed commit of the following:

And future devs will probably not care about the path we took to get to the final commit ;). They will want to know why we decided to make this change though. Something like:

docs/user/troubleshooting: Document 'core' user and SSH key injection

Previously, these platform-agnostic docs left users guessing about which username to use when SSHing in.

And folks with AWS experience might be surprised that we don't use AWS key pairs, so add some wording to avoid them thinking the lack of an AWS key pair is the source of their SSH issues.

[ldomb]

Ok updated the commit message

…

On Thu, Jan 3, 2019 at 2:45 PM W. Trevor King ***@***.***> wrote: Can you rework the commit message? The subject is not very specific now: $ git log --oneline -1 origin/pr/986c910e4d Squashed commit of the following: And future devs will probably not care about the path we took to get to the final commit ;). They will want to know why we decided to make this change though. Something like: docs/user/troubleshooting: Document 'core' user and SSH key injection Previously, these platform-agnostic docs left users guessing about which username to use when SSHing in. And folks with AWS experience might be surprised that we don't use AWS key pairs, so add some wording to avoid them thinking the lack of an AWS key pair is the source of their SSH issues. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#986 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABarZilpHKCdZ-04OjmJ5bSd9YNEhAv9ks5u_l32gaJpZM4ZoHdq> .

[wking]

/lgtm

Thanks for hanging in through all the review :)

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ldomb, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment