-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implementation to remove prepared #184
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asm582 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please have descriptive titles and at least some section on what this PR is. At a glance, it isn't clear to the reviewer what you want this to achieve. |
still in draft. |
Thanks @kannon92 this is WIP for now hence the draft PR, a few more changes are coming in, once done I prefer to update it all at once. |
@asm582: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/lgtm |
This PR removes the prepared section from the InstaSlice CR. We can now populate MIGs and co-relate them with allocations in the InstaSlice CR. Changes are made to the CRD, controller and daemonset. The obvious effect of this is increased system performance and determinism.
make lint
,make test
,make test-e2e
and daemonset shell scripts all pass locally.