Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation to remove prepared #184

Merged
merged 5 commits into from
Oct 21, 2024
Merged

Conversation

asm582
Copy link
Contributor

@asm582 asm582 commented Oct 18, 2024

This PR removes the prepared section from the InstaSlice CR. We can now populate MIGs and co-relate them with allocations in the InstaSlice CR. Changes are made to the CRD, controller and daemonset. The obvious effect of this is increased system performance and determinism. make lint, make test, make test-e2e and daemonset shell scripts all pass locally.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
Copy link

openshift-ci bot commented Oct 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asm582

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@kannon92
Copy link
Contributor

Please have descriptive titles and at least some section on what this PR is.

At a glance, it isn't clear to the reviewer what you want this to achieve.

@harche
Copy link
Contributor

harche commented Oct 18, 2024

Please have descriptive titles and at least some section on what this PR is.

still in draft.

@asm582
Copy link
Contributor Author

asm582 commented Oct 18, 2024

Thanks @kannon92 this is WIP for now hence the draft PR, a few more changes are coming in, once done I prefer to update it all at once.

@asm582 asm582 changed the title initial impl to rem prepared implementation to remove prepared Oct 18, 2024
@asm582 asm582 marked this pull request as ready for review October 18, 2024 15:53
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@asm582 asm582 requested a review from rphillips October 18, 2024 15:53
Copy link

openshift-ci bot commented Oct 21, 2024

@asm582: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@harche
Copy link
Contributor

harche commented Oct 21, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@asm582 asm582 merged commit 7bd130a into openshift:main Oct 21, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants