Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pipeline-sync] Pipeline build, started before Jenkins is deployed, gets deleted #139

Closed
tnozicka opened this issue Aug 11, 2016 · 8 comments · Fixed by jenkinsci/openshift-sync-plugin#7

Comments

@tnozicka
Copy link
Contributor

If I create a pipeline BC and trigger it for the first time, it triggers jenkins deployment into that namespace and deletes the build. Starting it for the second time, after Jenkins is deployed, works.

Steps to reproduce:

  1. $ oc cluster up --version=v1.3.0-alpha.3 && oc process -f https://github.com/tnozicka/nodejs-ex/raw/kontinu8-next/.openshift-pipeline/pipeline-template.yaml -v 'GIT_URL=https://github.com/tnozicka/nodejs-ex.git,GIT_REF=kontinu8-next' | oc apply -f - && oc start-build nodejs-ex-pipeline && oc get build
  2. you can see build nodejs-ex-pipeline-1

  3. wait until Jenkins is deployed and ready

  4. $ oc get build # shows no build at all
  5. $ oc start-build nodejs-ex-pipeline
  6. $ oc get build # will show only the second one (nodejs-ex-pipeline-2) (+the source build)

@bparees

@bparees
Copy link
Contributor

bparees commented Aug 11, 2016

@gabemontero @jimmidyson i can't imagine what is deleting these builds (but i was able to recreate). Are there any conditions under which the sync plugin would delete a build out of openshift?

@bparees
Copy link
Contributor

bparees commented Aug 11, 2016

it certainly used to be that if you created the build before jenkins existed, it would simply get run when jenkins started up (though there were some issues reported about cases where it didn't run it, but it certainly didn't delete it)

@jimmidyson
Copy link
Contributor

jimmidyson commented Aug 11, 2016

The sync plugin deletes builds if the BuildConfig Jenkins job is deleted. IIRC that's the only place where OS builds are deleted.

@gabemontero
Copy link
Contributor

Yep, the pipeline plugin does not delete builds.

On Thu, Aug 11, 2016 at 10:31 AM, Jimmi Dyson notifications@github.com
wrote:

The sync plugin deletes builds if the BuildConfig is deleted. IIRC that's
the only place where OS builds are deleted.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#139 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADbadL9Iw1lSPfIEMxVUd0JhdlEvXtVHks5qezI5gaJpZM4JiH2o
.

@bparees
Copy link
Contributor

bparees commented Aug 11, 2016

QE has also just reported this issue here:
https://bugzilla.redhat.com/show_bug.cgi?id=1366223

I would have to assume the sync plugin is doing it, @jimmidyson is there some debug we can turn on or logging that would show up when the sync plugin deletes a build?

@bparees
Copy link
Contributor

bparees commented Aug 11, 2016

@jimmidyson and it seems likely this is related:
https://bugzilla.redhat.com/show_bug.cgi?id=1366200

(old builds being deleted when the buildconfig is modified)

@tnozicka
Copy link
Contributor Author

It has been happening for at least a week or 2. I just got myself to properly investigate it today, sorry.

Also, as @bparees mentioned, there was a problem even before Summit that the first build failed when triggered by ConfigChange, but we have removed that trigger so I am not sure if it's an issue anymore.

@jimmidyson
Copy link
Contributor

Sorry about that - fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants