-
Notifications
You must be signed in to change notification settings - Fork 16
[release-v1.5] Support config to deploy internal certificates automatically #1236
[release-v1.5] Support config to deploy internal certificates automatically #1236
Conversation
mgencur
commented
Sep 6, 2022
- Add manifest patch for internal-tls to openshift/release/artifacts
- Support config to deploy internal certificates automatically
- Modify scripts in openshift/ to enable internal tls and tls for cluster-local gateway
- Pull the new make target for running tls tests from "main" branch.
- Tests for encryption with Kourier local gateway
…ase/artifacts` (knative#1202) * Add secret to 1.5 CI yaml * auto generated
…#13005) * Add certificate reconciler for internal certs * Fix cert path * Temporary use local networking repo * Support internal-encryption configuration * Use const for cert name * Fix lint * rm blank line * Drop unused variable * Use one line style * Use one line code * Update net-kourier nightly bumping knative.dev/net-kourier d758682...b9b1e8b: > b9b1e8b Use `internal-encryption` to deploy internal certificates automatically (# 855) > 427434c bump kind and k8s versions in kind-e2e tests (# 859) Signed-off-by: Knative Automation <automation@knative.team> * Verify SecretPKKey as well * Do not drop activator always in the path * Comment about ctrl-ca suffix Co-authored-by: Knative Automation <automation@knative.team>
* Enable internal-tls on OCP 4.8 * Use tls to match JOB name
* Add a target to enable internal-tls in Makefile * Update CI template for internal-tls enabled
* Generate Secrets * Commit generated cert-secret.yaml * httpproxy enables tls client * httpproxy uses https when CA_CERT specified * Pass CA_CERT and SERVER_NAME env variables properly to tests * Avoid using cluster-local certificates for external services
* Need to create test resources including the test namespace first before installing Knative so that applying test/config/tls/cert-secret.yaml succeeds
It works! Reverting the temporary commit for enabling tls by default. |
Testing it again after openshift-knative/net-kourier#24 was merged. |
The failures are unrelated to these changes. OCP 4.7 fails with https://issues.redhat.com/browse/SRVKS-946 (this can be seen in ingress operator pod). |
This reverts commit 5bb3549.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mgencur: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |