Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Reconcile on all private service events in KPA. (#7514) #445

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Reconcile on all private service events in KPA. (#7514) #445

merged 1 commit into from
Apr 7, 2020

Commits on Apr 6, 2020

  1. Reconcile on all private service events in KPA. (knative#7514) 

    We used to have a metrics service which the KPA watched and reacted to. We got rid of that and now have a race condition if we specify minScale but the SKS becomes ready with less than minScale pods. Nothing after that will ever kick the KPA to reconcile again.

This fixes that by watching the private services to make sure the KPA sees every change in deployment size. It itself keys off of the private services too to calculate the current replicas, closing the loop here.
    @markusthoemmes
    markusthoemmes committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    06bfe12 View commit details
    Browse the repository at this point in the history