Fix getPodFn namespace issue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, waitfordelete does not do what is intended because the getPodFn uses an empty namespace. This commit fixes that to use proper namespace for the pod.
openshift-ci-robot
added
the
size/XS
|
/approve |
michaelgugino
added a commit
to mgugino-upstream-stage/cluster-api
that referenced
this pull request
Jul 12, 2019
This commit updates kubernetes-drain to remove namespace bug. kubernetes-drain pr: openshift/kubernetes-drain#1
|
One thing I wanted to verify is whether this flaw existed in upstream kube, and as far as I can tell it never did. It looks like the flaw was introduced by a patch specific to this library: b43d446 |
runcom
added a commit
to runcom/machine-config-operator
that referenced
this pull request
Jul 30, 2019
xref openshift/kubernetes-drain#1 tl;dr; the drain function wasn't correctly waiting for all pods to be gone before reporting success. Signed-off-by: Antonio Murdaca <runcom@linux.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/machine-config-operator
that referenced
this pull request
Jul 31, 2019
xref openshift/kubernetes-drain#1 tl;dr; the drain function wasn't correctly waiting for all pods to be gone before reporting success. Signed-off-by: Antonio Murdaca <runcom@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, waitfordelete does not do what is intended
because the getPodFn uses an empty namespace.
This commit fixes that to use proper namespace for
the pod.