-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-15866: remove readiness check for cache exclusion #1625
OCPBUGS-15866: remove readiness check for cache exclusion #1625
Conversation
@JoelSpeed: This pull request references Jira Issue OCPBUGS-15866, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoelSpeed: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
/payload-aggregate periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade 10 Running payload aggregation job to ensure disruption metrics look good for this change |
@JoelSpeed: trigger 1 job(s) for the /payload-(job|aggregate) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e66dfd20-1be6-11ee-817a-b995f8cf4a76-0 |
/test e2e-aws-csi |
/retest |
Verify failed, seemingly because of go modules, is this normal? My PR shouldn't have affected the go modules |
@JoelSpeed: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
e30dd44
to
73febd4
Compare
@JoelSpeed: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
master PR is in openshift/cloud-provider-azure#77 so this is good as is for 4.13, overriding the valid-bug |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label backport-risk-assessed
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
typecheck failure is a known problem tracked in https://issues.redhat.com/browse/OCPBUGS-16176 |
@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test integration |
/retest-required |
/label cherry-pick-approved |
@ShudiLi: Can not set label cherry-pick-approved: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cancel /label cherry-pick-approved |
/label cherry-pick-approved |
@JoelSpeed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@JoelSpeed: Jira Issue OCPBUGS-15866: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-15866 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This readiness check is causing issues when adding and removing nodes from the cluster. See kubernetes-sigs/cloud-provider-azure#4230 for details.
Upstream have set a milestone to fix this for 1.28, but we need it in 1.27 and 1.26 so will merge here and create a backport for the in-tree provider for 1.26.
This will go directly to the 4.13 branch to solve the release-1.26 issue.
For 4.14 the Azure CCM will be the default choice and this in-tree code will not be executed, therefore no change required in master for this repo.