Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15866: remove readiness check for cache exclusion #1625

Conversation

JoelSpeed
Copy link

This readiness check is causing issues when adding and removing nodes from the cluster. See kubernetes-sigs/cloud-provider-azure#4230 for details.

Upstream have set a milestone to fix this for 1.28, but we need it in 1.27 and 1.26 so will merge here and create a backport for the in-tree provider for 1.26.

This will go directly to the 4.13 branch to solve the release-1.26 issue.
For 4.14 the Azure CCM will be the default choice and this in-tree code will not be executed, therefore no change required in master for this repo.

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 6, 2023
@openshift-ci-robot
Copy link

@JoelSpeed: This pull request references Jira Issue OCPBUGS-15866, which is invalid:

  • expected dependent Jira Issue OCPBUGS-14762 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This readiness check is causing issues when adding and removing nodes from the cluster. See kubernetes-sigs/cloud-provider-azure#4230 for details.

Upstream have set a milestone to fix this for 1.28, but we need it in 1.27 and 1.26 so will merge here and create a backport for the in-tree provider for 1.26.

This will go directly to the 4.13 branch to solve the release-1.26 issue.
For 4.14 the Azure CCM will be the default choice and this in-tree code will not be executed, therefore no change required in master for this repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@JoelSpeed: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@JoelSpeed
Copy link
Author

/payload-aggregate periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade 10

Running payload aggregation job to ensure disruption metrics look good for this change

@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2023

@JoelSpeed: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.13-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e66dfd20-1be6-11ee-817a-b995f8cf4a76-0

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh July 6, 2023 10:21
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jul 6, 2023
@bertinatto
Copy link
Member

/test e2e-aws-csi

@JoelSpeed
Copy link
Author

/retest

@JoelSpeed
Copy link
Author

Verify failed, seemingly because of go modules, is this normal? My PR shouldn't have affected the go modules

@openshift-ci-robot
Copy link

@JoelSpeed: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci-robot
Copy link

@JoelSpeed: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@soltysh
Copy link

soltysh commented Jul 13, 2023

master PR is in openshift/cloud-provider-azure#77 so this is good as is for 4.13, overriding the valid-bug

@soltysh soltysh added backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 13, 2023
Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 13, 2023
@soltysh
Copy link

soltysh commented Jul 13, 2023

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@JoelSpeed
Copy link
Author

/retest

@soltysh
Copy link

soltysh commented Jul 13, 2023

typecheck failure is a known problem tracked in https://issues.redhat.com/browse/OCPBUGS-16176
/override ci/prow/verify

@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

@soltysh: Overrode contexts on behalf of soltysh: ci/prow/verify

In response to this:

typecheck failure is a known problem tracked in https://issues.redhat.com/browse/OCPBUGS-16176
/override ci/prow/verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link

soltysh commented Jul 13, 2023

/test integration

@JoelSpeed
Copy link
Author

/retest-required

@ShudiLi
Copy link
Member

ShudiLi commented Jul 14, 2023

/label cherry-pick-approved
thanks

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

@ShudiLi: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to this:

/label cherry-pick-approved
thanks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShudiLi
Copy link
Member

ShudiLi commented Jul 14, 2023

cancel /label cherry-pick-approved

@gangwgr
Copy link

gangwgr commented Jul 14, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 14, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f245ced and 2 for PR HEAD 73febd4 in total

@openshift-ci
Copy link

openshift-ci bot commented Jul 14, 2023

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 73febd4 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 73ac561 into openshift:release-4.13 Jul 14, 2023
@openshift-ci-robot
Copy link

@JoelSpeed: Jira Issue OCPBUGS-15866: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-15866 has not been moved to the MODIFIED state.

In response to this:

This readiness check is causing issues when adding and removing nodes from the cluster. See kubernetes-sigs/cloud-provider-azure#4230 for details.

Upstream have set a milestone to fix this for 1.28, but we need it in 1.27 and 1.26 so will merge here and create a backport for the in-tree provider for 1.26.

This will go directly to the 4.13 branch to solve the release-1.26 issue.
For 4.14 the Azure CCM will be the default choice and this in-tree code will not be executed, therefore no change required in master for this repo.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.