Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.17] OCPBUGS-42620: Include bootstrap IP in etcd endpoints list #1814

Open
wants to merge 1 commit into
base: release-4.17
Choose a base branch
from
Open

[release-4.17] OCPBUGS-42620: Include bootstrap IP in etcd endpoints list #1814

wants to merge 1 commit into from
+16 −8

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1807

/assign vrutkovs

@vrutkovs
Include bootstrap IP in etcd endpoints list
50d2967 
During bootstrap kube-apiserver points to master etcd instances.
These instances are being added to etcd-servers list one by one,
to ensure that if any master can't reach some other etcds this revision
 won't block the entire rollout.
 However, at some point the masters may end up with just one etcd
 (localhost and its IP), which makes it non-HA and apiserver may
 lose etcd connection if this etcd is being reconfigured.

This change updates the list to include bootstrap etcd so that
any master would always have an etcd instance to connect to.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 1, 2024
Merged
@openshift-ci openshift-ci bot requested review from hasbro17 and hexfusion October 1, 2024 08:09
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42083 has been cloned as Jira Issue OCPBUGS-42620. Will retitle bug to link to clone.
/retitle [release-4.17] OCPBUGS-42620: Include bootstrap IP in etcd endpoints list

In response to this:

This is an automated cherry-pick of #1807

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.17] OCPBUGS-42083: Include bootstrap IP in etcd endpoints list [release-4.17] OCPBUGS-42620: Include bootstrap IP in etcd endpoints list Oct 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 1, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42620, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-42083 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1807

/assign vrutkovs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dusk125
Copy link
Contributor

dusk125 commented Oct 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dusk125, openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign hasbro17 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasbro17 hasbro17 Awaiting requested review from hasbro17

@hexfusion hexfusion Awaiting requested review from hexfusion

Assignees

@vrutkovs vrutkovs

@dusk125 dusk125

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-ci-robot @dusk125 @vrutkovs