OCPBUGS-44374: CSI controller conditions should provide reason and message

[RomanBednar]

This change warns about reason and message fields in conditions being mandatory in the future: https://github.com/openshift/library-go/pull/1804/files#diff-49fde404f27181b69aea013be73a1439f91fcef3e1c11701f49fe01a5cef6268R351-R356

Causing overhaul of warning messages for controllers that don't set those:

W1125 12:50:39.932013   42393 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverControllerServiceControllerAvailable"].reason is missing; this will eventually be fatal
W1125 12:50:39.932042   42393 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverControllerServiceControllerAvailable"].message is missing; this will eventually be fatal
W1125 12:50:39.932047   42393 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverControllerServiceControllerProgressing"].reason is missing; this will eventually be fatal
W1125 12:50:39.932050   42393 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverControllerServiceControllerProgressing"].message is missing; this will eventually be fatal

W1125 14:48:15.962871   57793 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverNodeServiceControllerAvailable"].reason is missing; this will eventually be fatal
W1125 14:48:15.962883   57793 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverNodeServiceControllerAvailable"].message is missing; this will eventually be fatal
W1125 14:48:15.962887   57793 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverNodeServiceControllerProgressing"].reason is missing; this will eventually be fatal
W1125 14:48:15.962891   57793 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverNodeServiceControllerProgressing"].message is missing; this will eventually be fatal

With this patch the messages will always be set, although they're not very helpful:

  - lastTransitionTime: "2024-11-25T11:49:08Z"
    message: Deployment is available
    reason: AsExpected
    status: "True"
    type: AWSEFSDriverControllerServiceControllerAvailable
  - lastTransitionTime: "2024-11-25T11:50:06Z"
    message: Deployment is not progressing
    reason: AsExpected
    status: "False"
    type: AWSEFSDriverControllerServiceControllerProgressing
  - lastTransitionTime: "2024-11-25T11:49:08Z"
    message: DaemonSet is available
    reason: AsExpected
    status: "True"
    type: AWSEFSDriverNodeServiceControllerAvailable
  - lastTransitionTime: "2024-11-25T13:48:11Z"
    message: DaemonSet is not progressing
    reason: AsExpected
    status: "False"
    type: AWSEFSDriverNodeServiceControllerProgressing

cc @openshift/storage

[openshift-ci-robot]

@RomanBednar: This pull request references Jira Issue OCPBUGS-44374, which is invalid:

• expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change warns about reason and message fields in conditions being mandatory in the future: https://github.com/openshift/library-go/pull/1804/files#diff-49fde404f27181b69aea013be73a1439f91fcef3e1c11701f49fe01a5cef6268R351-R356

Causing overhaul of warning messages for controllers that don't set those:

W1125 12:50:39.932013   42393 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverControllerServiceControllerAvailable"].reason is missing; this will eventually be fatal
W1125 12:50:39.932042   42393 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverControllerServiceControllerAvailable"].message is missing; this will eventually be fatal
W1125 12:50:39.932047   42393 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverControllerServiceControllerProgressing"].reason is missing; this will eventually be fatal
W1125 12:50:39.932050   42393 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverControllerServiceControllerProgressing"].message is missing; this will eventually be fatal

W1125 14:48:15.962871   57793 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverNodeServiceControllerAvailable"].reason is missing; this will eventually be fatal
W1125 14:48:15.962883   57793 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverNodeServiceControllerAvailable"].message is missing; this will eventually be fatal
W1125 14:48:15.962887   57793 dynamic_operator_client.go:352] .status.conditions["AWSEFSDriverNodeServiceControllerProgressing"].reason is missing; this will eventually be fatal
W1125 14:48:15.962891   57793 dynamic_operator_client.go:355] .status.conditions["AWSEFSDriverNodeServiceControllerProgressing"].message is missing; this will eventually be fatal

With this patch the messages will always be set, although they're not very helpful:

 - lastTransitionTime: "2024-11-25T11:49:08Z"
   message: Deployment is available
   reason: AsExpected
   status: "True"
   type: AWSEFSDriverControllerServiceControllerAvailable
 - lastTransitionTime: "2024-11-25T11:50:06Z"
   message: Deployment is not progressing
   reason: AsExpected
   status: "False"
   type: AWSEFSDriverControllerServiceControllerProgressing
 - lastTransitionTime: "2024-11-25T11:49:08Z"
   message: DaemonSet is available
   reason: AsExpected
   status: "True"
   type: AWSEFSDriverNodeServiceControllerAvailable
 - lastTransitionTime: "2024-11-25T13:48:11Z"
   message: DaemonSet is not progressing
   reason: AsExpected
   status: "False"
   type: AWSEFSDriverNodeServiceControllerProgressing

cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RomanBednar
Once this PR has been reviewed and has the lgtm label, please assign jsafrane for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• pkg/operator/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.