Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community.yaml: Update sources to C9S/UBI9 #350

Merged

Conversation

LorbusChris
Copy link
Member

Removes stale and deprecated sources

Removes stale and deprecated sources
@LorbusChris
Copy link
Member Author

/cc @vrutkovs
/assign @gabemontero

@fbm3307
Copy link
Contributor

fbm3307 commented Aug 31, 2023

Taking a look at this PR

@gabemontero gabemontero removed their assignment Aug 31, 2023
@gabemontero
Copy link
Contributor

/assign @fbm3307

@LorbusChris
Copy link
Member Author

Note that the only manual change here was to community.yaml - the rest of the changes is generated from that.

@fbm3307
Copy link
Contributor

fbm3307 commented Sep 4, 2023

@LorbusChris yes , but i do need to make sure it doesn't interfere with Cluster Samples operator, as CSO is currently being downsized and hence the delay.

@LorbusChris
Copy link
Member Author

@fbm3307
Copy link
Contributor

fbm3307 commented Sep 6, 2023

@LorbusChris will be approving this PR, but just FYI, that we are downsizing cluster samples operator, The phase-1 of it is already in progress and by year end we will pull out the support for Non-s2i samples and then there are plans for converting S2i ones to helmcharts. so CSO will stop managing the imagestreams/templates. so if you are updating this for long term basis you might want to consider other option if these are meant for openshift.

@fbm3307
Copy link
Contributor

fbm3307 commented Sep 6, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fbm3307, LorbusChris, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2023
@LorbusChris
Copy link
Member Author

@fbm3307 thanks for the context. I'm not really attached to the samples operator, so all that's fine with me.

This change is mainly to get rid of references to docker.io in the samples we ship today, as those make us hit rate limits in CI.

@fbm3307
Copy link
Contributor

fbm3307 commented Sep 6, 2023

@LorbusChris okay makes sense

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 6, 2023

@LorbusChris: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 099bc68 into openshift:master Sep 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants