Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OLS-1256: Add OLS ARM builds to Konflux - operator #542

Merged
merged 2 commits into from
Dec 3, 2024
Merged

OLS-1256: Add OLS ARM builds to Konflux - operator #542

merged 2 commits into from
Dec 3, 2024

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Nov 25, 2024 •
edited
Loading

Description

Add OLS ARM builds to Konflux - operator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 25, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1256 which is a valid jira issue.

In response to this:

Description

Add OLS ARM builds to Konflux

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@syedriko
Copy link
Contributor Author

/retest

@syedriko
Copy link
Contributor Author

@xrajesh PTAL. I changed the builder images to refer to multi-platform indices.

@syedriko syedriko changed the title OLS-1256: Add OLS ARM builds to Konflux OLS-1256: Add OLS ARM builds to Konflux - operator Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024 •
edited by openshift-ci bot
Loading

@syedriko: This pull request references OLS-1256 which is a valid jira issue.

In response to this:

Description

Add OLS ARM builds to Konflux - operator

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2024
@syedriko
Red Hat Konflux update lightspeed-operator
d06a8c3 
Signed-off-by: red-hat-konflux <konflux@no-reply.konflux-ci.dev>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@syedriko
Copy link
Contributor Author

syedriko commented Dec 2, 2024

/retest

1 similar comment
@syedriko
Copy link
Contributor Author

syedriko commented Dec 2, 2024

/retest

@xrajesh
Copy link
Contributor

xrajesh commented Dec 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@xrajesh
Copy link
Contributor

xrajesh commented Dec 2, 2024

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"
/override "Red Hat Konflux / rapidast-scan / lightspeed-operator"

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / ols-enterprise-contract / lightspeed-operator, Red Hat Konflux / rapidast-scan / lightspeed-operator

In response to this:

/approve
/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"
/override "Red Hat Konflux / rapidast-scan / lightspeed-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@xrajesh
Copy link
Contributor

xrajesh commented Dec 3, 2024

/lgtm
/approve "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xrajesh
Copy link
Contributor

xrajesh commented Dec 3, 2024

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / ols-enterprise-contract / lightspeed-operator

In response to this:

/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 627b322 into openshift:main Dec 3, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuawilson joshuawilson Awaiting requested review from joshuawilson

@xrajesh xrajesh Awaiting requested review from xrajesh

Assignees

@xrajesh xrajesh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@syedriko @openshift-ci-robot @xrajesh @openshift-merge-robot