Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-1256: Add OLS ARM builds to Konflux - bundle #544

Merged

Conversation

syedriko
Copy link
Contributor

@syedriko syedriko commented Nov 26, 2024

Description

OLS-1256: Add OLS ARM builds to Konflux - bundle

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@syedriko: This pull request references OLS-1256 which is a valid jira issue.

In response to this:

Description

OLS-1256: Add OLS ARM builds to Konflux - bundle

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2024

@syedriko: This pull request references OLS-1256 which is a valid jira issue.

In response to this:

Description

OLS-1256: Add OLS ARM builds to Konflux - bundle

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@syedriko syedriko force-pushed the syedriko-ols-1256-bundle branch 4 times, most recently from 7f274de to 2f4e11a Compare November 26, 2024 19:03
@syedriko
Copy link
Contributor Author

@xrajesh PTAL. I changed the bundle base image to refer to a multi-platform index.

@syedriko syedriko force-pushed the syedriko-ols-1256-bundle branch from 2f4e11a to 2c8d495 Compare November 29, 2024 00:26
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 30, 2024
@syedriko syedriko force-pushed the syedriko-ols-1256-bundle branch from 2c8d495 to f37bcfc Compare December 2, 2024 03:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2024
@syedriko
Copy link
Contributor Author

syedriko commented Dec 2, 2024

/retest

@xrajesh
Copy link
Contributor

xrajesh commented Dec 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@xrajesh
Copy link
Contributor

xrajesh commented Dec 2, 2024

/approve
/override "Red Hat Konflux / ols-enterprise-contract / bundle"
/override "Red Hat Konflux / rapidast-scan / lightspeed-operator"

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2024
Copy link

openshift-ci bot commented Dec 2, 2024

@xrajesh: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / rapidast-scan / lightspeed-operator

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / ols-enterprise-contract / bundle
  • Red Hat Konflux / rapidast-scan / bundle
  • ci/prow/bundle-e2e-4-17
  • ci/prow/ci-index-lightspeed-bundle-test
  • ci/prow/fips-image-scan-operator
  • ci/prow/security
  • pull-ci-openshift-lightspeed-operator-main-bundle-e2e-4-17
  • pull-ci-openshift-lightspeed-operator-main-ci-index-lightspeed-bundle-test
  • pull-ci-openshift-lightspeed-operator-main-fips-image-scan-operator
  • pull-ci-openshift-lightspeed-operator-main-security
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/approve
/override "Red Hat Konflux / ols-enterprise-contract / bundle"
/override "Red Hat Konflux / rapidast-scan / lightspeed-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrajesh
Copy link
Contributor

xrajesh commented Dec 2, 2024

/approve
/override "Red Hat Konflux / ols-enterprise-contract / bundle"
/override "Red Hat Konflux / rapidast-scan / bundle"

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 2, 2024

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / ols-enterprise-contract / bundle, Red Hat Konflux / rapidast-scan / bundle

In response to this:

/approve
/override "Red Hat Konflux / ols-enterprise-contract / bundle"
/override "Red Hat Konflux / rapidast-scan / bundle"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Dec 2, 2024

@syedriko: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 530071e into openshift:main Dec 2, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants