NO-JIRA: minor LSO build improvements

[dobsonj]

This PR includes a few small improvements for LSO contributors:

• make clean: remove controller-gen

  It's easy for bin/controller-gen to become outdated, especially when working with different release branches, which can cause make update to fail. This change removes bin/controller-gen as part of make clean, same as yq and other binaries.

• make bundle: always start with empty opm-bundle dir

  When running make bundle, any old manifests in your existing opm-bundle dir can be included in the newly generated bundle. For example, I had some NetworkPolicy manifests in my local opm-bundle dir that were included in a build that doesn't support that object type, which caused install to fail. This is easily avoidable by starting with a clean opm-bundle dir every time make bundle is used.

• make test: pin setup-envtest version to v0.21.0

  ci/prow/unit fails because it tries to pull the latest version, which requires go1.25, and our go version isn't there yet. This commit pins the setup-envtest version to v0.21.0 which is compatible with go1.24 and k8s 1.33.

/cc @openshift/storage

[openshift-ci-robot]

@dobsonj: This pull request explicitly references no jira issue.

Details

In response to this:

This PR makes two small improvements for LSO contributors:

• make clean: remove controller-gen

It's easy for bin/controller-gen to become outdated, especially when working with different release branches, which can cause make update to fail. This change removes bin/controller-gen as part of make clean, same as yq and other binaries.

• make bundle: always start with empty opm-bundle dir

When running make bundle, any old manifests in your existing opm-bundle dir can be included in the newly generated bundle. For example, I had some NetworkPolicy manifests in my local opm-bundle dir that were included in a build that doesn't support that object type, which caused install to fail. This is easily avoidable by starting with a clean opm-bundle dir every time make bundle is used.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

This PR makes two small improvements for LSO contributors:

• make clean: remove controller-gen

It's easy for bin/controller-gen to become outdated, especially when working with different release branches, which can cause make update to fail. This change removes bin/controller-gen as part of make clean, same as yq and other binaries.

• make bundle: always start with empty opm-bundle dir

When running make bundle, any old manifests in your existing opm-bundle dir can be included in the newly generated bundle. For example, I had some NetworkPolicy manifests in my local opm-bundle dir that were included in a build that doesn't support that object type, which caused install to fail. This is easily avoidable by starting with a clean opm-bundle dir every time make bundle is used.

/cc @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dobsonj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jsafrane]

/lgtm

[jsafrane]

/verified by CI

[openshift-ci-robot]

@jsafrane: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.