Skip to content

Commit

Permalink
Merge pull request #4707 from isabella-janssen/ocpbugs-27477-pausing-…
Browse files Browse the repository at this point in the history
…alert

OCPBUGS-27477: Pausing Master MCP results in Alerts
  • Loading branch information
openshift-merge-bot[bot] authored Dec 6, 2024
2 parents 657b65f + 46fb474 commit 6778953
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/operator/sync.go
Original file line number Diff line number Diff line change
Expand Up @@ -1734,6 +1734,9 @@ func (optr *Operator) syncRequiredMachineConfigPools(config *renderConfig, co *c
}
// If we don't account for pause here, we will spin in this loop until we hit the 10 minute timeout because paused pools can't sync.
if pool.Spec.Paused {
if isPoolStatusConditionTrue(pool, mcfgv1.MachineConfigPoolUpdated) {
return false, fmt.Errorf("the required MachineConfigPool %s was paused with no pending updates; no further syncing will occur until it is unpaused", pool.Name)
}
return false, fmt.Errorf("error required MachineConfigPool %s is paused and cannot sync until it is unpaused", pool.Name)
}
return false, nil
Expand Down

0 comments on commit 6778953

Please sign in to comment.