Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "templates: change etcd-member to notify type" #106

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

abhinavdahiya
Copy link
Contributor

Reverts #104

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 2, 2018
@abhinavdahiya abhinavdahiya requested review from crawford and removed request for wking and yifan-gu October 2, 2018 23:03
@rphillips
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@crawford
Copy link
Contributor

crawford commented Oct 2, 2018

This results in podman hanging (we aren't sure why yet). The process tree ends up looking something like the following when podman is hung:

root      1385  0.0  0.0  85888   576 ?        Ssl  22:51   0:00 /usr/libexec/podman/conmon -s -c df7610aaab9be49f16cf9c69d184e21cd6fbecc05ce5fe630b598f1a4b644ad2 -u df7610aaab9be49f16cf9c69d184e21cd6fbecc05ce5fe630b598f1a4b644ad2 -r /usr/bin/runc -b /var
root      1386  0.0  0.5 206436 11376 ?        Sl   22:51   0:00 /usr/bin/runc --systemd-cgroup create --bundle /var/lib/containers/storage/overlay-containers/df7610aaab9be49f16cf9c69d184e21cd6fbecc05ce5fe630b598f1a4b644ad2/userdata --pid-file /var/run/co
etcd      1396  0.0  0.3  54512  6404 ?        Ssl  22:51   0:00 /usr/bin/runc init

@openshift-merge-robot openshift-merge-robot merged commit 8123b0b into master Oct 2, 2018
@abhinavdahiya abhinavdahiya deleted the revert-104-etcd branch October 2, 2018 23:07
@crawford
Copy link
Contributor

crawford commented Oct 2, 2018

The root cause of the failure is fixed by opencontainers/runc#1807 (which has been open for quite a while).

osherdp pushed a commit to osherdp/machine-config-operator that referenced this pull request Apr 13, 2021
change operator ID from 'instance' to 'cluster'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants