Bug 1753932: OpenStack: Ensure haproxy pod has the needed resources #1125
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
Sorry for the lack of context, I'm in a bit of a hurry and wanted to push my changes quicly. I'll improve the PR description in a couple of hours. |
|
/test e2e-openstack |
|
Looks like this fixed the QoS errors. The other one (tollerations) should be fixed by this patch: |
|
/test e2e-aws-op |
One of the consequences of making the static pods known to k8s in openshift#1122 is that now the smoke test complain that some of the pods do not comply with the requirements. By adding resources claim to the haproxy pod, we ensure it is not running with best-effort QoS. This fixes the "[Feature:Platform][Smoke] Managed cluster should ensure control plane pods do not run in best-effort QoS [Suite:openshift/conformance/parallel]" failure in e2e-openstack job. Fixes bz#1753932
mandre
force-pushed
the
openstack-haproxy-qos
branch
from
c6d5615
to
31ec054
Compare
|
/bugzilla refresh |
|
@mandre: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mandre
changed the title
|
@mandre: This pull request references Bugzilla bug 1753932, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/assign @runcom |
|
/bugzilla refresh |
|
@tomassedovic: This pull request references Bugzilla bug 1753932, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
|
/test e2e-openstack |
|
/hold We'll revert #1122 instead as this is really urgent. |
openshift-ci-robot
added
the
do-not-merge/hold
|
@yboaron ptal |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, mandre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@mandre: All pull requests linked via external trackers have merged. Bugzilla bug 1753932 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Following the fixed proposed on openshift#1125 Signed-off-by: Roy Golan <rgolan@redhat.com>
Following the fixed proposed on openshift#1125 Signed-off-by: Roy Golan <rgolan@redhat.com>
One of the consequences of making the static pods known to k8s in #1122 is that now the smoke test complain that some of the pods do not comply with the requirements.
By adding resources claim to the
haproxypod, we ensure it is not running with best-effort QoS.This fixes the "[Feature:Platform][Smoke] Managed cluster should ensure control plane pods do not run in best-effort QoS [Suite:openshift/conformance/parallel]" failure in e2e-openstack job.