Bug 1882667: daemon: Unlink encapsulated config in once-from mode #2120
Conversation
Unconditionally remove this file in the once-from (classic RHEL) case. We use this file to suppress things like kubelet and SDN starting on CoreOS during the firstboot/pivot boot, but there's no such thing on classic RHEL.
openshift-ci-robot
requested review from
ericavonb and
kikisdeliveryservice
openshift-ci-robot
added
the
approved
|
Makes sense to me!! As this file isn't removed and can break other things 👍 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kikisdeliveryservice The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We hit this in : BZ 1882667 so I'll link but im not sure if this fix closes the BZ alone @dcbw |
kikisdeliveryservice
changed the title
openshift-ci-robot
added
the
bugzilla/severity-urgent
|
@cgwalters: This pull request references Bugzilla bug 1882667, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@cgwalters: All pull requests linked via external trackers have merged: Bugzilla bug 1882667 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| if err := os.Remove(constants.MachineConfigEncapsulatedPath); err != nil { | ||
| return errors.Wrapf(err, "failed to remove %s", constants.MachineConfigEncapsulatedPath) | ||
| } | ||
| } |
There was a problem hiding this comment.
this should be run after the once from is run - this is a RHEL node so when this run we're effectively writing the encapsulated mc at the end of this, which results, obviously, in the file being there. We should move this at the end.
|
@cgwalters ptal #2125 |
Unconditionally remove this file in the once-from (classic RHEL)
case. We use this file to suppress things like kubelet and SDN
starting on CoreOS during the firstboot/pivot boot, but there's
no such thing on classic RHEL.