Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2041364: Afterburn to try config-drive before Nova metadata #2915

Closed
wants to merge 1 commit into from
Closed

[release-4.9] Bug 2041364: Afterburn to try config-drive before Nova metadata #2915

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2903

/assign pierreprinetti

@pierreprinetti @mandre
Afterburn to try config-drive before Nova metadata
a9339c6 
With this change, the afterburn-hostname service uses the 'openstack'
provider, which fetches userdata from the config drive, and only uses
the Nova metadata service as a fallback. This is especially useful in
network topologies where Nova-metadata is not guaranteed to be reachable
(e.g. when using baremetal (Ironic) instances).

Co-authored-by: Martin André <m.andre@redhat.com>
Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 17, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@openshift-cherrypick-robot: Bugzilla bug 2033953 has been cloned as Bugzilla bug 2041364. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2041364: Afterburn to try config-drive before Nova metadata

In response to this:

[release-4.9] Bug 2033953: Afterburn to try config-drive before Nova metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2033953: Afterburn to try config-drive before Nova metadata [release-4.9] Bug 2041364: Afterburn to try config-drive before Nova metadata Jan 17, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2041364, which is invalid:

  • expected dependent Bugzilla bug 2033953 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2041364: Afterburn to try config-drive before Nova metadata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 17, 2022
@openshift-ci openshift-ci bot requested review from EmilienM and iamemilio January 17, 2022 08:39
@pierreprinetti
Copy link
Member

/test e2e-openstack
/approve
/lgtm
/hold for ci

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-workers-rhel7 a9339c6 link false /test e2e-aws-workers-rhel7
ci/prow/okd-e2e-upgrade a9339c6 link false /test okd-e2e-upgrade
ci/prow/e2e-aws-disruptive a9339c6 link false /test e2e-aws-disruptive
ci/prow/e2e-aws-workers-rhel8 a9339c6 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-vsphere-upgrade a9339c6 link false /test e2e-vsphere-upgrade
ci/prow/okd-e2e-gcp-op a9339c6 link false /test okd-e2e-gcp-op
ci/prow/e2e-aws-upgrade-single-node a9339c6 link false /test e2e-aws-upgrade-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Contributor

@pierreprinetti which job are you waiting on?

@pierreprinetti
Copy link
Member

@kikisdeliveryservice the openstack one, which succeeded! Thanks for the reminder. Now just waiting for the verification of the parent bug.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@pierreprinetti
Copy link
Member

/retest-required

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

/backport-risk-assessed

@kikisdeliveryservice
Copy link
Contributor

/skip

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2022

@openshift-bot: This pull request references Bugzilla bug 2041364, which is invalid:

  • expected dependent Bugzilla bug 2033953 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@openshift-bot: This pull request references Bugzilla bug 2041364, which is invalid:

  • expected dependent Bugzilla bug 2033953 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Member

Parent bz failed QA
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2022
@pierreprinetti
Copy link
Member

/close
We are looking into the connectivity issue to the Nova metadata service instead.

@openshift-ci openshift-ci bot closed this Jan 21, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2022

@pierreprinetti: Closed this PR.

In response to this:

/close
We are looking into the connectivity issue to the Nova metadata service instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@iamemilio iamemilio Awaiting requested review from iamemilio

Assignees

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @pierreprinetti @kikisdeliveryservice @openshift-bot