Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2060133: Explicitly set keyfile as the default plugin #2984

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Bug 2060133: Explicitly set keyfile as the default plugin #2984

merged 1 commit into from
Mar 8, 2022

Conversation

jcaamano
Copy link
Contributor

@jcaamano jcaamano commented Mar 4, 2022

This was originally set as such in 4.9. But it was removed what it seems inadvertently in 4.10 at the same time systemConnectionsMerged overlay was removed. We still want keyfile to be the default plugin, which it already is for RHCOS but not for RHEL. Set it back.

Signed-off-by: Jaime Caamaño Ruiz jcaamano@redhat.com

- What I did

- How to verify it

- Description for the changelog

@jcaamano
Explicitly set keyfile as the default plugin
342f20b 
Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
@openshift-ci openshift-ci bot requested review from cgwalters and mkenigs March 4, 2022 15:56
@jcaamano jcaamano changed the title Explicitly set keyfile as the default plugin Bug 2060133: Explicitly set keyfile as the default plugin Mar 4, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2022

@jcaamano: This pull request references Bugzilla bug 2060133, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "4.10.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2060133: Explicitly set keyfile as the default plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

jcaamano commented Mar 4, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@jcaamano: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

jcaamano commented Mar 4, 2022

/retest

@trozet
Copy link
Contributor

trozet commented Mar 5, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2022

@trozet: This pull request references Bugzilla bug 2060133, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@trozet
Copy link
Contributor

trozet commented Mar 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2022
@trozet
Copy link
Contributor

trozet commented Mar 5, 2022

/assign @kikisdeliveryservice

@zhaozhanqi
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 7, 2022
yuqi-zhang
yuqi-zhang approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, trozet, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2022
@cgwalters
Copy link
Member

I'm OK with this, but ISTM we could also make this change in openshift-ansible since we only care about making traditional RHEL work the same way as RHCOS.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Mar 8, 2022
Merged
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2022 •
edited
Loading

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 342f20b link false /test e2e-aws-disruptive
ci/prow/e2e-aws-workers-rhel8 342f20b link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-upgrade-single-node 342f20b link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-aws-single-node 342f20b link false /test e2e-aws-single-node
ci/prow/e2e-metal-ipi 342f20b link false /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f55abd2 into openshift:master Mar 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2022

@jcaamano: All pull requests linked via external trackers have merged:

Bugzilla bug 2060133 has been moved to the MODIFIED state.

In response to this:

Bug 2060133: Explicitly set keyfile as the default plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 8, 2022
Closed
@openshift-cherrypick-robot
Copy link

@jcaamano: new pull request created: #2991

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@cgwalters cgwalters Awaiting requested review from cgwalters

@mkenigs mkenigs Awaiting requested review from mkenigs

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@kikisdeliveryservice kikisdeliveryservice

@trozet trozet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jcaamano @openshift-cherrypick-robot @trozet @zhaozhanqi @cgwalters @openshift-bot @yuqi-zhang @kikisdeliveryservice @openshift-merge-robot