-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump(openshift/api): to get CSI changes #3010
Bump(openshift/api): to get CSI changes #3010
Conversation
Run everything that looks related /test e2e-aws-proxy |
In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder. As a result, we need to stop force-disabling the feature gates because that doesn't have any effect anymore.
a7e5cf9
to
47040f5
Compare
/assign @kikisdeliveryservice @yuqi-zhang |
I fixed an unit test and the set of tests is not persistent, so let's do it again /test e2e-aws-proxy |
/test e2e-openstack They both failed in terraform, IMO before this PR could do any damage. |
/test e2e-azure It almost succeeded, the only failure was |
/lgtm |
/test e2e-azure-upgrade Again, almost succeeded, just |
Does this work? |
Oh sorry, we did get a green on that. |
/approve |
/skip |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, cgwalters, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
/retest-required Please review the full test history for this PR and help us cut down flakes. |
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder.
As a result, we need to stop force-disabling the feature gates because
that doesn't have any effect anymore.
cc @openshift/storage
Note: our last attempt #2949 broke Azure jobs and needed a revert. Azure CSI driver should be fixed now by openshift/azure-disk-csi-driver-operator#44, still, watch for Azure and OpenStack regressions!