Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump(openshift/api): to get CSI changes #3010

Merged
merged 1 commit into from
Mar 12, 2022

Conversation

jsafrane
Copy link
Contributor

In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder.
As a result, we need to stop force-disabling the feature gates because
that doesn't have any effect anymore.

cc @openshift/storage

Note: our last attempt #2949 broke Azure jobs and needed a revert. Azure CSI driver should be fixed now by openshift/azure-disk-csi-driver-operator#44, still, watch for Azure and OpenStack regressions!

@jsafrane
Copy link
Contributor Author

Run everything that looks related

/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade
/test e2e-aws-upgrade-single-node
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp-op-single-node
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-parallel
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upgrade
/test e2e-vsphere-upi

In upstream, CSI migration is GA for Azure Disk and OpenStack Cinder.
As a result, we need to stop force-disabling the feature gates because
that doesn't have any effect anymore.
@bertinatto
Copy link
Member

/assign @kikisdeliveryservice @yuqi-zhang

@jsafrane
Copy link
Contributor Author

I fixed an unit test and the set of tests is not persistent, so let's do it again

/test e2e-aws-proxy
/test e2e-aws-serial
/test e2e-aws-single-node
/test e2e-aws-upgrade
/test e2e-aws-upgrade-single-node
/test e2e-azure
/test e2e-azure-upgrade
/test e2e-gcp-op-single-node
/test e2e-gcp-single-node
/test e2e-gcp-upgrade
/test e2e-metal-ipi
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack
/test e2e-openstack-parallel
/test e2e-ovirt
/test e2e-ovirt-upgrade
/test e2e-ovn-step-registry
/test e2e-vsphere
/test e2e-vsphere-upgrade
/test e2e-vsphere-upi

@jsafrane
Copy link
Contributor Author

/test e2e-openstack
/test e2e-openstack-parallel

They both failed in terraform, IMO before this PR could do any damage.

@jsafrane
Copy link
Contributor Author

/test e2e-azure

It almost succeeded, the only failure was [bz-etcd][invariant] alert/etcdHighNumberOfFailedGRPCRequests should not be at or above info

@bertinatto
Copy link
Member

/lgtm
From Storage Team

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2022
@jsafrane
Copy link
Contributor Author

/test e2e-azure-upgrade

Again, almost succeeded, just [sig-network] pods should successfully create sandboxes by not timing out. So far, all failures look unrelated to this PR.

@cgwalters
Copy link
Member

Does this work?
/test e2e-azure

@cgwalters
Copy link
Member

Oh sorry, we did get a green on that.

@cgwalters
Copy link
Member

/approve

@cgwalters
Copy link
Member

/skip

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, cgwalters, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 12, 2022

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-single-node 47040f5 link false /test e2e-aws-single-node
ci/prow/e2e-gcp-single-node 47040f5 link false /test e2e-gcp-single-node
ci/prow/e2e-gcp-op-single-node 47040f5 link false /test e2e-gcp-op-single-node
ci/prow/e2e-aws-workers-rhel8 47040f5 link false /test e2e-aws-workers-rhel8
ci/prow/e2e-aws-disruptive 47040f5 link false /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi-ovn-ipv6 47040f5 link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/okd-e2e-aws 47040f5 link false /test okd-e2e-aws
ci/prow/e2e-azure 47040f5 link false /test e2e-azure
ci/prow/e2e-aws-upgrade-single-node 47040f5 link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-openstack-parallel 47040f5 link false /test e2e-openstack-parallel
ci/prow/e2e-vsphere-upgrade 47040f5 link false /test e2e-vsphere-upgrade
ci/prow/e2e-azure-upgrade 47040f5 link false /test e2e-azure-upgrade
ci/prow/e2e-vsphere 47040f5 link false /test e2e-vsphere
ci/prow/e2e-openstack 47040f5 link false /test e2e-openstack

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 00f8f43 into openshift:master Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants