Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: Bump containers/image #3303

Merged

Conversation

cgwalters
Copy link
Member

Prep for #3302

We should either use dependabot for openshift/ or use another
similar tool.

Prep for openshift#3302

We should either use dependabot for openshift/ or use another
similar tool.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@sinnykumari
Copy link
Contributor

LGTM
Just want to be sure that newer version doesn't break any ctrcfg stuff.
/assign @haircommander PTAL

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

@sinnykumari: GitHub didn't allow me to assign the following users: PTAL.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

LGTM
Just want to be sure that newer version doesn't break any ctrcfg stuff.
/assign @haircommander PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Member

LGTM, @QiWang19 can you give a +1? I am less familiar with ISCP or IDMS which could more readily be broken by this, though I find it unlikely they will be

Copy link
Member

@QiWang19 QiWang19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is safe to bump. LGTM

@QiWang19
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, QiWang19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 29d06d8 and 8 for PR HEAD c65f847 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 8aead4c into openshift:master Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants