-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Drop -operator
from ClusterOperator object name
#376
Conversation
for consistency
Hi @LorbusChris. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@LorbusChris: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
This has been pointed out by Clayton on slack for context |
I see how the CLI name is passed into where we create the clusteroperator CRD, but I'd be a bit surprised if this was the only place that needed changing. We can try it though; looks like the kubelet unit tests are failing which is odd. |
/approve |
/test unit |
In https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/376/pull-ci-openshift-machine-config-operator-master-e2e-aws/1453/artifacts/e2e-aws/clusteroperators.json Specifically
Also note that we're degraded presumably due to #367 - the fact that we haven't been gating any PRs or release payloads on nodes not being degraded has been really problematic - but it's unrelated to this PR. I just noticed that there's a convenient dump of the clusteroperator status. |
/lgtm |
3 similar comments
/lgtm |
/lgtm |
/lgtm |
@kikisdeliveryservice: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ashcrow: changing LGTM is restricted to assignees, and assigning you to the PR failed. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashcrow, cgwalters, kikisdeliveryservice, LorbusChris, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
for consistency