-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync status tests #443
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
holding caues waiting on #442 /hold |
f7e19f9
to
1c9501f
Compare
Fix a bug reported in openshift#406 (comment) where we weren't properly resetting the failing status. Signed-off-by: Antonio Murdaca <runcom@linux.com>
1c9501f
to
66b3ac7
Compare
Specifically, add a test to verify that we're clearing out the failing condition on subsequent sync operations (covering a bug reported here openshift#406 (comment)) Signed-off-by: Antonio Murdaca <runcom@linux.com>
66b3ac7
to
9d0dd24
Compare
Signed-off-by: Antonio Murdaca <runcom@linux.com>
9d0dd24
to
ac3eb7f
Compare
please take a look at ac3eb7f and identify other cases if you can as well |
those units are too important actually, the code added is just in testing anyway. Adding this to #442 |
- What I did
This PR builds on #442 so let's hold until that merges.
The sync status is one of the most important thing we need NOT to regress on.
What the last commit really does is setting up a way to easily add more unit tests for the sync calls to avoid regression. I've modified the test in #442 to use the new way and added 2 other smoke tests. The aim is to add even more to cover the majority of the cases. (if not all)
For now, just review the last commit until #442 merges
- How to verify it
Run the unit tests
- Description for the changelog