Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No-Issue: Remove OCL Extensions test #4868

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

No-Issue: Remove OCL Extensions test #4868

wants to merge 1 commit into from
+1 −47

Conversation

umohnani8
Copy link
Contributor

@umohnani8 umohnani8 commented Feb 20, 2025 •
edited
Loading

- What I did
We will be switching to using the legacy method of installing extensions instead of doing it in the containerfile for OCL. Remove the test as it is failing constantly and blocking PRs
Reference bug https://issues.redhat.com/browse/OCPBUGS-51130

- How to verify it
The e2e-ocl tests should pass now

- Description for the changelog
Remove ocl extensions test

@umohnani8
Remove OCL Extensions test
1c2b862 
We will be switching to using the legacy method of installing
extensions instead of doing it in the containerfile for OCL.
Remove the test as it is failing constantly and blocking PRs

Signed-off-by: Urvashi <umohnani@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2025
@openshift-ci-robot
Copy link
Contributor

@umohnani8: This pull request explicitly references no jira issue.

In response to this:

- What I did
We will be switching to using the legacy method of installing extensions instead of doing it in the containerfile for OCL. Remove the test as it is failing constantly and blocking PRs

- How to verify it
The e2e-ocl tests should pass now

- Description for the changelog
Remove ocl extensions test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2025
dkhater-redhat
dkhater-redhat approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@dkhater-redhat dkhater-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: we will be looking to revert this once we get extensions sorted on the OCL side

@djoshy
Copy link
Contributor

djoshy commented Feb 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, dkhater-redhat, umohnani8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [djoshy,dkhater-redhat,umohnani8]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d34ac99 and 2 for PR HEAD 1c2b862 in total

@umohnani8
Copy link
Contributor Author

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 22, 2025

@umohnani8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 1c2b862 link false /test e2e-agent-compact-ipv4
ci/prow/e2e-gcp-op 1c2b862 link true /test e2e-gcp-op
ci/prow/e2e-hypershift 1c2b862 link true /test e2e-hypershift
ci/prow/e2e-vsphere-ovn-upi-zones 1c2b862 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-upi 1c2b862 link false /test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhater-redhat dkhater-redhat dkhater-redhat approved these changes

@djoshy djoshy Awaiting requested review from djoshy

@isabella-janssen isabella-janssen Awaiting requested review from isabella-janssen

Assignees

@djoshy djoshy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@umohnani8 @openshift-ci-robot @djoshy @dkhater-redhat