[release-4.20] OCPNODE-3883: Remove the dead code of setting the operator status for cgroupv1 based clusters #5446
Conversation
clusters - Option of configuring cgroupv1 has been removed in OCP - 4.19 - It is safe to remove this check from the operator status for all the clusters greater than OCP - 4.19 - Also removed the cluster fleet evaluation that checks if a cluster is configured with cgroupv1 Signed-off-by: Sai Ramesh Vanka <svanka@redhat.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@sairameshv: This pull request references OCPNODE-3883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@sairameshv: This pull request references OCPNODE-3883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
left a comment
isabella-janssen
left a comment
There was a problem hiding this comment.
/approve
/label backport-risk-assessed
This looks like a fair change to me as the OCP docs do indicate that a cluster with cgroup v1 cannot upgrade to 4.19, which makes the removed block of code unnecessary, and is a clean backport.
openshift-ci
bot
added
the
backport-risk-assessed
openshift-ci
bot
assigned
anuragthehatter,
eurijon,
imatza-rh,
lyman9966,
mhanss,
ptalgulk01,
rbbratta,
rioliu-rh,
sergiordlr and
zhaozhanqi
openshift-ci
bot
added
the
approved
|
@sairameshv: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: isabella-janssen, QiWang19, sairameshv The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
14 participants
Manual backport of #5399