Skip to content

AGENT-1326: Add InternalReleaseImage controller #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2025
Merged

AGENT-1326: Add InternalReleaseImage controller #5452

merged 4 commits into from
Dec 2, 2025
+5,275 −16

Conversation

@andfasano
Copy link
Contributor

@andfasano andfasano commented Nov 28, 2025 •
edited
Loading

  • What I did

    • Add a new sub-controller to manage the InternalReleaseImage resource
    • Add a related bootstrap command for template generation during the cluster install

  • How to verify it
    Add the InternalReleaseImage resource in the bootstrap manifests dir (/etc/mcc/bootstrap) and enable the feature gate.

  • Description for the changelog
    Add support for InternalReleaseImage resource

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2025 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Work currently in progress!

  • What I did

  • Add a new sub-controller to manage the InternalReleaseImage resource

  • Add a related bootstrap command for template generation during the cluster install

  • How to verify it
    Add the InternalReleaseImage resource in the bootstrap manifests dir (/etc/mcc/bootstrap) and enable the feature gate.

  • Description for the changelog
    Add support for InternalReleaseImage resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 28, 2025
@andfasano andfasano mentioned this pull request Nov 28, 2025
Closed
@andfasano andfasano changed the title [WIP] AGENT-1326: Add InternalReleaseImage controller AGENT-1326: Add InternalReleaseImage controller Dec 1, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 1, 2025 •
edited by openshift-ci bot
Loading

@andfasano: This pull request references AGENT-1326 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

  • What I did

  • Add a new sub-controller to manage the InternalReleaseImage resource

  • Add a related bootstrap command for template generation during the cluster install

  • How to verify it
    Add the InternalReleaseImage resource in the bootstrap manifests dir (/etc/mcc/bootstrap) and enable the feature gate.

  • Description for the changelog
    Add support for InternalReleaseImage resource

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Dec 1, 2025
Merged
Merged
Open
pablintino
pablintino reviewed Dec 1, 2025
View reviewed changes
pkg/controller/internalreleaseimage/internalreleaseimage_controller.go Outdated
const (
maxRetries = 15

iriRole = "master"
Copy link
Contributor

@pablintino pablintino Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use

machine-config-operator/pkg/controller/common/constants.go

Line 70 in 5db32f8

MachineConfigPoolMaster = "master"
?

Copy link
Contributor Author

@andfasano andfasano Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure added

pablintino
pablintino reviewed Dec 1, 2025
View reviewed changes
@andfasano
vendoring openshift client-go and api
a2178bf 
This is required to import the InternalReleaseImage resource (and related MachineConfigNode changes) to support the NoRegistryClusterInstall feature
@andfasano
add docker-registry image to clusterconfig
51051b8
@andfasano
add InternalReleaseImage bootstrap template generation
de7d985 
During the machine-config-controller bootstrap command, a specific machine-config managed by the InternalReleaseImage controller is generated and appended to the master ignition
@andfasano
add InternalReleaseImage controller
1e795e3 
This controller takes care of the IRI deletion, and it avoids any machine config drifting - by generating or updating the IRI owned machine config
@pablintino
Copy link
Contributor

pablintino commented Dec 2, 2025

/lgtm
/test unit

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2025
@andfasano
Copy link
Contributor Author

andfasano commented Dec 2, 2025

/verified later @andfasano

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 2, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

@andfasano: This PR has been marked to be verified later by @andfasano.

In response to this:

/verified later @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@andfasano andfasano mentioned this pull request Dec 2, 2025
Open
@andfasano
Copy link
Contributor Author

andfasano commented Dec 2, 2025

/test e2e-hypershift

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 4a64f2f and 2 for PR HEAD 1e795e3 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 2, 2025

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/bootstrap-unit 1e795e3 link false /test bootstrap-unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8e6beb0 into openshift:main Dec 2, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@umohnani8 umohnani8 Awaiting requested review from umohnani8

1 more reviewer

@pablintino pablintino pablintino left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@pablintino pablintino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andfasano @openshift-ci-robot @pablintino