BZ1714769: fix kubeletconfig with empty MCPs status updates #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @sjenning |
openshift-ci-robot
added
the
size/S
openshift-ci-robot
requested review from
sjenning,
kikisdeliveryservice and
LorbusChris
runcom
reviewed
Jun 3, 2019
| @@ -59,6 +60,9 @@ var updateBackoff = wait.Backoff{ | |||
| Jitter: 1.0, | |||
| } | |||
|
|
|||
| // ErrCouldNotFindMCPSet Error if no MCPs could be found | |||
| var ErrCouldNotFindMCPSet = errors.New("could not find any MachineConfigPool set for KubeletConfig") | |||
There was a problem hiding this comment.
it doesn't.... I have removed the export in the force push.
Do not requeue the key if there are zero MCPs. Prevents multiple status updates and will not succeed. ref: https://bugzilla.redhat.com/show_bug.cgi?id=1714769
rphillips
force-pushed
the
fixes/bz1714769
branch
from
e87d171
to
c0f7151
Compare
rphillips
changed the title
|
lgtm, thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
registry hiccups in CI :( |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Do not requeue the key if there are zero MCPs. Prevents multiple status updates and will not succeed.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1714769
- How to verify it
- Description for the changelog