Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'eus' channel #470

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use 'eus' channel #470

wants to merge 1 commit into from

Conversation

jewzaam
Copy link
Member

@jewzaam jewzaam commented Aug 20, 2024

What type of PR is this?

feature

What this PR does / why we need it?

uses "eus" channel for 4.12+ even versions

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/SDCICD-1365

Special notes for your reviewer:

do not promote to prod until this bakes in int/stage for a while

Pre-checks (if applicable):

  • Tested latest changes against a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot requested review from a7vicky and ravitri August 20, 2024 17:44
Copy link
Contributor

openshift-ci bot commented Aug 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jewzaam
Once this PR has been reviewed and has the lgtm label, please assign bmeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jewzaam
Copy link
Member Author

jewzaam commented Aug 20, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.32%. Comparing base (ccd9e44) to head (5cf31ae).

Files Patch % Lines
pkg/ocmprovider/ocmprovider.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
- Coverage   54.34%   54.32%   -0.02%     
==========================================
  Files         122      122              
  Lines        5903     5905       +2     
==========================================
  Hits         3208     3208              
- Misses       2494     2495       +1     
- Partials      201      202       +1     
Files Coverage Δ
pkg/ocmprovider/ocmprovider.go 63.80% <0.00%> (-1.24%) ⬇️

Copy link
Contributor

openshift-ci bot commented Sep 4, 2024

@jewzaam: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants