Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret key ref name to username and password env in upload container #140

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

AlexVulaj
Copy link
Contributor

@AlexVulaj AlexVulaj commented Jun 24, 2024

Fixes a bug that was missed in #138 - we weren't using the secret key ref name to properly reference username/password envars in the upload container.

Relevant slack thread: https://redhat-internal.slack.com/archives/C016S65RNG5/p1718723911684519

@openshift-ci openshift-ci bot requested review from bng0y and devppratik June 24, 2024 18:17
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.78%. Comparing base (44bbf4a) to head (f97aa15).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #140       +/-   ##
===========================================
+ Coverage    7.83%   36.78%   +28.95%     
===========================================
  Files           5        5               
  Lines         383      386        +3     
===========================================
+ Hits           30      142      +112     
+ Misses        350      241      -109     
  Partials        3        3               
Files Coverage Δ
controllers/mustgather/template.go 87.50% <80.00%> (+87.50%) ⬆️

@AlexVulaj AlexVulaj force-pushed the secret-key-ref-name branch from c4a806a to 4471233 Compare June 24, 2024 18:33
@AlexVulaj AlexVulaj force-pushed the secret-key-ref-name branch from 4471233 to f97aa15 Compare June 24, 2024 18:35
Copy link
Contributor

@mjlshen mjlshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 24, 2024

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b5e4345 into openshift:master Jun 24, 2024
6 checks passed
@AlexVulaj AlexVulaj deleted the secret-key-ref-name branch June 24, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants